Repository navigation
Conversation
On desktop platforms TextSelectionGestureDetectorBuilder sets the selection on tap down, where a shift-click extends it. MacosTextField placed the caret again on tap up, so the extended selection flashed and collapsed as soon as the mouse button was released. Like Flutter's own builder, it now leaves the selection to tap down on macOS, Windows and Linux. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS (and Windows/Linux), placing the caret in a
MacosTextFieldand then shift-clicking elsewhere shows the extended selection for an instant, and it collapses as soon as the mouse button is released.Why: Flutter's
TextSelectionGestureDetectorBuildersets the selection on tap down on desktop platforms, which is where a shift-click extends it; itsonSingleTapUpdeliberately does nothing there ("On desktop platforms the selection is set on tap down")._TextFieldSelectionGestureDetectorBuilder.onSingleTapUpcalledrenderEditable.selectPositionunconditionally, collapsing the selection on release. Drag selection was not affected because it ends inonDragSelectionEnd.Fix: skip
selectPositionon tap up on desktop platforms; mobile behaviour is unchanged.Tests: a shift-click test over
TargetPlatformVariant.desktop()(fails before the fix) and a plain-click test over all platforms.Pre-launch Checklist
CHANGELOG.mdwith my changes (added under the unreleased 2.2.3)🤖 Generated with Claude Code