Repository navigation
Conversation
The selection highlight was the accent color at 20% opacity, hard to read in the dark appearance. It is now an opaque tint of the accent, close to NSColor.selectedTextBackgroundColor: with the blue accent #B3D7FF in the light appearance and about #3F638B in the dark one. The new selectionColor parameter overrides it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selection highlight of
MacosTextFieldis the accent color at 20% opacity. In the dark appearance it is hard to tell what is selected.Change: the default is now an opaque tint of the accent, close to the color macOS paints behind selected text (
NSColor.selectedTextBackgroundColor):lerp(white, accent, 0.3)in the light appearance andlerp(#5A5A5A, accent, 0.3)in the dark one. With the blue accent these give#B3D7FF(the system value) and about#3F638B. The accent is the same one the cursor already uses (AccentColorListener, falling back to the theme'sprimaryColor). A newselectionColorparameter overrides the default.This is an appearance change, so I kept it separate from the shift-click fix; happy to adjust the values or make it opt-in.
Tests: the default is opaque in both appearances and darker in the dark one;
selectionColoroverrides it.Pre-launch Checklist
CHANGELOG.mdwith my changes (2.3.0: new parameter)🤖 Generated with Claude Code