Repository navigation
Complete rscada fixture coverage and fix exposed decoding errors - #151
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.
Check all 100 rscada captures against XML or explicit error expectations, including fixed counters and record metadata, values and units. Known fixture exceptions are documented beside their assertions.
Fix three bugs exposed by these checks: misplaced DIFE storage bits, missing duration units, and extended energy units using W³/h instead of Wh. Integer/BCD comparisons are exact; only floats allow XML rounding.
Validation: 180 workspace tests passed with each plaintext layout; all-feature tests, formatting, targeted Clippy and the embedded no_std build passed. Fixture tests and targeted Clippy also pass after review. Broader all-target Clippy still reports pre-existing warnings in unchanged tests.