Repository navigation
perf: decode common BCD fields with integer arithmetic - #152
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common BCD fields now accumulate two digits at a time in
u64and convert tof64once. Byte-aligned values through 14 digits use this path; longer values retain the original floating-point accumulation and rounding. Sign markers, byte ordering, invalid-digit errors, and positive zero are preserved.Adds focused Criterion cases and differential coverage against the original floating-point decoder, including all 65,536 two-byte encodings and sampled values through 18 digits.
Validation:
cargo test --all-featurespass.thumbv7m-none-eabino_std build pass.Native Criterion comparison on this aarch64 Mac (
opt-level=z, 30 samples, 1s warm-up, 2s measurement): 2/8/12-digit cases improved about 5%/30%/37%. Full-frame decode had no statistically detected change. The unchanged 18-digit arithmetic path measured about 5% slower, with the unrelated frame-only control also about 4% slower; native timing remains noisy. These are not MCU cycle measurements; embedded stack/flash impact remains for CI resource checks.