Skip to content

fix: publish macOS release assets - #5

Merged
lurenyang418 merged 1 commit into
mainfrom
fix/release-gpui-macos-assets
Oct 12, 2026
Merged

lurenyang418 merged 1 commit into
mainfrom
fix/release-gpui-macos-assets

Conversation

@lurenyang418

Copy link
Copy Markdown

移除 release workflow 中 macOS 的 debug artifact suffix,避免稳定公开 DMG 和 updater 资产被发布脚本过滤。

Copilot AI balanced review requested due to automatic review settings October 12, 2026 13:04
@lurenyang418
lurenyang418 merged commit e7daa54 into main Oct 12, 2026
1 of 3 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It exposes ad-hoc-signed, unnotarized builds as stable macOS release assets.

1 open finding
What changed in this PR

Removes macOS debug suffixes so GPUI release assets pass publication filters.

Changes:

  • Publishes stable-named macOS DMG and updater assets.
  • Applies naming changes to both macOS architectures.
File Description
.github/​workflows/​release-gpui.yml Removes macOS artifact suffixes from build/package matrices.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@@ -182,11 +180,9 @@ jobs:
- id: macos-aarch64
os: macos-26
target: aarch64-apple-darwin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants