Repository navigation
Conversation
Bashev
requested review from
a team,
SamueleMartini and
dadolun95
as code owners
August 24, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MigrateConfigPaths data patch calls StoreManager::getWebsites()/getStores() unconditionally in apply(). On a clean setup:install the data patches run before the default website exists, so WebsiteRepository throws \DomainException("The default website isn't defined") and the whole install aborts.
This wraps the website/store iteration in a narrow try/catch (\DomainException), falling back to migrating only the default scope. When no stores or websites exist yet there is nothing store-specific to migrate anyway, so the default scope is sufficient; on a normal upgrade (websites present) behaviour is unchanged.
The fix is applied as a Composer patch against the vendor package rather than a fork, so it travels with the project and drops away cleanly once the upstream module guards this itself.