Fix OpenAI translator: use Chat Completions - #75
Merged
Merged
Conversation
Girg-Z
requested review from
a team,
SamueleMartini and
dadolun95
as code owners
September 7, 2026 12:50
Collaborator
|
@Girg-Z Thank you for your contribution. Could you please also update the changelog file and add it to the pull request? I'll approve it as soon as you do. |
SamueleMartini
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74.
The translator called the legacy
/v1/completionsendpoint first and only fell back to Chat Completions when an exception was thrown. With current models, the legacy endpoint can return a200response with unusable content, so the fallback is never triggered and that content gets saved as the translation.chat()directly, removing the legacy/v1/completionsattempt.null.Backwards compatibility: Completion-only models are no longer supported, as they don't support
/v1/chat/completions.These should be base older models with limited capabilities, so they were unlikely to produce reliable translations anyway.