Skip to content

Don't load the view transitions on Hyvä #32

Description

@GrimLink

Summary

On Hyvä themes the module renders its view transitions style (@view-transition { navigation: auto; }) and script at the end of the body, but Hyvä already includes view transitions in its own theme CSS (Hyvä Default Theme 1.4+, web/tailwind/base/index.css). The output of the module duplicates that.

It also gets in the way of how Hyvä handles view transitions:

  • The Enable View Transitions and Apply on Back/Forward settings have no effect on Hyvä, since the theme CSS enables view transitions regardless.
  • The style is rendered after anything a Hyvä theme sets in the head, so it overrides a theme that disables or adjusts the cross-document view transition, like the Hyvä default theme does for the Facebook and Instagram in-app browser on Android (see Blank pages in Facebook and Instagram in-app browser on Android with view transitions #30).

Proposal

Remove the theme-optimization.view-transitions block in default_hyva.xml, like #29 does for the bfcache handler, and note on the view transitions settings that they have no effect on Hyvä themes. Luma behavior stays unchanged.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions