Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Hyvä Default Theme 1.4+ includes view transitions in its theme CSS (
@view-transition { navigation: auto; }), so the view transitions style and script of this module only duplicated that. Because they are rendered at the end of the body, they also override anything a Hyvä theme sets for view transitions, such as the fix for the Facebook and Instagram in-app browser in the Hyvä default theme (see #30).default_hyva.xmlremoves thetheme-optimization.view-transitionsblock. Speculation rules, the bfcache response headers and the admin view transitions are untouched.Luma behaviour is unchanged. This touches
default_hyva.xmllike #29, so one of the two needs a small rebase after the other is merged.