Repository navigation
output-strategy: remove the panel byline; keep attribution in the README - #1009
Conversation
yetone
left a comment
yetone
left a comment
There was a problem hiding this comment.
Reviewed at 0d03f7b. Authorship checks out: every commit under packages/output-strategy (#814, #815, #849, #831) is yours, and so was the author field. Removing your own byline is fine.
One thing has to change before this can merge:
The version isn't bumped, so the change never reaches anyone. packages/output-strategy/package.json:3 is still 0.2.2. 0.2.2 is already packed on dist (tgz/magpie-community-middleware-output-strategy-0.2.2.tgz), and scripts/dist.mjs:11-12 never packs a version twice ("A version packed once is never packed again"). npm doesn't have this package at all, so dist is how it gets installed. Merged as is, every user keeps the 0.2.2 tarball with the byline and the author field. Please bump to 0.2.3.
What I ran at 0d03f7b (on the Mac test machine, temp HOME). It's already up to date with origin/main 1e5b1c8:
bun testin packages/output-strategy: 59 pass, 0 fail.bun scripts/check.mjs: ok. (node --testdoesn't apply here because the tests importbun:test. That's the same on main.)- Broke it by hand: I put back main's
page/index.htmland got 1 fail ("shows conversation guidance in both languages without a panel byline"). I did the same with main'spage/i18n.jsand got the same 1 fail. So the new assertions do guard the change. - Rendered the page in Playwright 1.62 Chromium and WebKit at 1200 and 420px, in en and zh-CN, with a stub bridge. No byline, the conversation note shows, all 7 styles load, no horizontal overflow, no page errors.
Once the bump is in, I'll run the root suite and merge.
|
Bumped to 0.2.3, thanks! Re-ran on 121f571: |
) Test only. Adds a codearts regression for #1007's fix (029c628): the IDE's -wal is rewritten within one clock tick, with the main database's bytes, the sidecar's size and its mtime unchanged, and the reader still picks up the new credential. No package bump: nothing shipped changes. Run at the reviewed head d53a142 (on mote, temp HOME): - packages/codearts `bun test`: 203 pass, 0 fail. `bun scripts/check.mjs`: ok. - Root `bun test` (suite lock) on origin/main a69931e merged with #1009, #1012 and #1013: 8373 pass, 0 fail (8392 tests across 590 files, 361s; the rest skipped), on Linux (Ubuntu 24.04, magpie-desktop) because both Macs' suite locks were held by hours-long runs. `bun scripts/check.mjs` on that tree: ok. Broken by hand: ideReader's sidecar loop changed to `for (const suffix of [])`, so -wal and -journal no longer go into the stamp. Only the new test fails (202 pass, 1 fail: "the IDE's write-ahead log rewritten in one clock tick is read again"); none of the existing tests caught it. With the code restored, it passes. Not tried: a real CodeArts Agent IDE writing its WAL. Co-authored-by: zhou.han <18181754+yetihan@users.noreply.github.com>
Gives Amp Usage's registry entry an `icon`, so the store card shows the package's own icon instead of the generic page one. It points at packages/amp-usage/page/icon.svg in this repo on main, the same way Window Warmup and 书生·端砚 do, so only this repo's maintainers can change what it serves. Run at the reviewed head 8a8049f (on mote, temp HOME): - `bun scripts/check.mjs`: ok. `bun test scripts`: 22 pass, 0 fail. packages/amp-usage `node --test`: 47 pass, 0 fail. - The URL answers 200, image/svg+xml, 3391 bytes, the same bytes as the file on main (added in #1000). The SVG has no script or external reference. - Rendered the SVG as <img> at 20, 32 and 64px in Playwright 1.62 Chromium and WebKit: decodes, no page errors, the Amp wordmark reads at 20px. - Root `bun test` (suite lock) on origin/main a69931e merged with #1009, #1012 and #1013: 8373 pass, 0 fail (8392 tests across 590 files, 361s; the rest skipped), on Linux (Ubuntu 24.04, magpie-desktop) because both Macs' suite locks were held by hours-long runs. `bun scripts/check.mjs` on that tree: ok. Not tried: the store card in a real magpie after it fetches the new registry. Co-authored-by: ming jiang <jm1179356055@gmail.com>
The Output Strategy page renders an author byline under the header. The plugin author wants their name only in the README, not in the panel every user opens.
.attributionparagraph, its i18n entry and its CSS ruleauthormetadata; the README keeps the attributionNo middleware, options or request behavior changes.
Verification: standalone repo (same page code)
bun test53 pass, 0 fail; the modified community page test file ran on that code: 13 pass, 0 fail (Bun 1.4.4).