Repository navigation
registry: Amp Usage shows its icon in the store - #1013
Merged
Merged
Conversation
The page entry had no icon, so the Plugins tab showed the generic page glyph. Point it at the package's own page/icon.svg on main, as Window Warmup does. Amp-Thread-ID: https://ampcode.com/threads/T-01a1caea-5f86-7654-b535-fbec8b66ad64 Co-authored-by: Amp <amp@ampcode.com>
yetone
pushed a commit
that referenced
this pull request
Nov 11, 2026
) Test only. Adds a codearts regression for #1007's fix (029c628): the IDE's -wal is rewritten within one clock tick, with the main database's bytes, the sidecar's size and its mtime unchanged, and the reader still picks up the new credential. No package bump: nothing shipped changes. Run at the reviewed head d53a142 (on mote, temp HOME): - packages/codearts `bun test`: 203 pass, 0 fail. `bun scripts/check.mjs`: ok. - Root `bun test` (suite lock) on origin/main a69931e merged with #1009, #1012 and #1013: 8373 pass, 0 fail (8392 tests across 590 files, 361s; the rest skipped), on Linux (Ubuntu 24.04, magpie-desktop) because both Macs' suite locks were held by hours-long runs. `bun scripts/check.mjs` on that tree: ok. Broken by hand: ideReader's sidecar loop changed to `for (const suffix of [])`, so -wal and -journal no longer go into the stamp. Only the new test fails (202 pass, 1 fail: "the IDE's write-ahead log rewritten in one clock tick is read again"); none of the existing tests caught it. With the code restored, it passes. Not tried: a real CodeArts Agent IDE writing its WAL. Co-authored-by: zhou.han <18181754+yetihan@users.noreply.github.com>
yetone
pushed a commit
that referenced
this pull request
Nov 11, 2026
…he README (#1009) Removes the "by" byline from the Output Strategy panel (index.html, i18n.js, style.css); the attribution stays in the README. Bumps the package to 0.2.3 so dist packs it (0.2.2 is already packed and is never packed again). Run at the reviewed head 121f571 (on mote, temp HOME): - `git diff 0d03f7b 121f571`: only package.json 0.2.2 -> 0.2.3 and the matching version assertion in test/page.test.mjs. Everything else was reviewed at 0d03f7b. - packages/output-strategy `bun test`: 59 pass, 0 fail. `bun scripts/check.mjs`: ok. - Root `bun test` (suite lock) on origin/main a69931e merged with #1009, #1012 and #1013: 8373 pass, 0 fail (8392 tests across 590 files, 361s; the rest skipped), on Linux (Ubuntu 24.04, magpie-desktop) because both Macs' suite locks were held by hours-long runs. `bun scripts/check.mjs` on that tree: ok. - Earlier, at 0d03f7b: Playwright 1.62 Chromium and WebKit at 1200 and 420px, en and zh-CN, with a stub bridge. No byline, the conversation note shows, all 7 styles load, no horizontal overflow, no page errors. Broken by hand (at 0d03f7b): putting main's page/index.html back, or main's page/i18n.js, makes 1 test fail ("shows conversation guidance in both languages without a panel byline"). Not tried: the panel inside a real magpie window. Co-authored-by: manjughosa <3220325975@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1000 只在
package.json的magpie.page.icon配了页面图标，registry.json的条目缺icon，插件商店卡片显示通用页面图标。本 PR 给 Amp Usage 条目加上
icon，指向包内page/icon.svg在 main 上的 raw 地址，写法与 Window Warmup 一致。只改这一行。验证：
image/svg+xml，即 feat(amp-usage): add usage board and background collection #1000 合入的 Amp 官方 App Icon；128px 下预览正常。bun scripts/check.mjs：通过。bun test scripts：22 pass，0 fail。