Repository navigation
fix: point the author at a real profile and cut 1.2.1 - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A metadata patch. Nothing under
src/changes behaviour; what changes is whatthe package says about itself, which only reaches npm and React Native Directory
inside a published version.
package.jsonhad"author": "Majornutcracker <…> (JoshuaPariona)". npm reads the parenthesisedpart as a URL, so the registry stores
"url": "JoshuaPariona"and thedirectory renders it as a relative link —
reactnative.directory/package/@majornutcracker/JoshuaPariona, a 404. It nowpoints at
https://github.com/majornutcracker-dev.npx expo install, npm, yarn, pnpm andbun, each in its own fenced block so GitHub and npm give every command its own
copy button. It also says Expo Go needs nothing else.
docs/VERSION-UPDATE.mdwas written beforemainwas protected andbefore the Snack existed. Its flow said "push the commit to
main", which theruleset now refuses. It describes the PR-based flow, the tag ruleset (and that
a published version must never be re-tagged), and an After publishing
checklist covering npm, the Snack and the directory.
PATCHnow saysexplicitly that metadata and README changes belong to it.
bump: v1.2.1in the six places the guide lists, plus the two cosmeticones (
snack/package.json, the bug report placeholder).versionCode3 → 4.Type of change
fix— bug fix (no public API change)feat— new backward-compatible APIdocs/chore/ci/test— no runtime changeHow was this tested?
yarn lint,yarn typecheckandyarn test(156) pass on top of the currentmain, after syncing the lockfile from the merged Dependabot PRs. The releasedrift check from
release.ymlwas run locally and reports no drift, and nostray
1.2.0is left outside the changelog and the guide.Nothing here exercises native code or the WebView runtime, so no device run was
needed.
Checklist
yarn lint,yarn typecheck, andyarn testall pass.— N/A: this PR cutsCHANGELOG.mdupdated under## [Unreleased]the release, so the entries sit under
## [1.2.1] - 2026-10-09.I did not bump the version— N/A: this is the bump.Merging does not publish; pushing the
v1.2.1tag does.After merging, see After publishing in
docs/VERSION-UPDATE.md: the publishedSnack needs its pinned version raised by hand.