Skip to content

fix: point the author at a real profile and cut 1.2.1 - #21

Merged
majornutcracker-dev merged 4 commits into
mainfrom
chore/visibility2
Oct 10, 2026
Merged

majornutcracker-dev merged 4 commits into
mainfrom
chore/visibility2

Conversation

@JoshuaPariona

@JoshuaPariona JoshuaPariona commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

A metadata patch. Nothing under src/ changes behaviour; what changes is what
the package says about itself, which only reaches npm and React Native Directory
inside a published version.

  • The author link on the directory card is broken. package.json had
    "author": "Majornutcracker <…> (JoshuaPariona)". npm reads the parenthesised
    part as a URL, so the registry stores "url": "JoshuaPariona" and the
    directory renders it as a relative link —
    reactnative.directory/package/@majornutcracker/JoshuaPariona, a 404. It now
    points at https://github.com/majornutcracker-dev.
  • The README's install section lists npx expo install, npm, yarn, pnpm and
    bun, each in its own fenced block so GitHub and npm give every command its own
    copy button. It also says Expo Go needs nothing else.
  • docs/VERSION-UPDATE.md was written before main was protected and
    before the Snack existed. Its flow said "push the commit to main", which the
    ruleset now refuses. It describes the PR-based flow, the tag ruleset (and that
    a published version must never be re-tagged), and an After publishing
    checklist covering npm, the Snack and the directory. PATCH now says
    explicitly that metadata and README changes belong to it.
  • bump: v1.2.1 in the six places the guide lists, plus the two cosmetic
    ones (snack/package.json, the bug report placeholder). versionCode 3 → 4.

Type of change

  • fix — bug fix (no public API change)
  • feat — new backward-compatible API
  • Breaking change to the public API or the RN ↔ WebView bridge contract
  • docs / chore / ci / test — no runtime change

How was this tested?

yarn lint, yarn typecheck and yarn test (156) pass on top of the current
main, after syncing the lockfile from the merged Dependabot PRs. The release
drift check from release.yml was run locally and reports no drift, and no
stray 1.2.0 is left outside the changelog and the guide.

Nothing here exercises native code or the WebView runtime, so no device run was
needed.

  • iOS (example app) — not applicable, no runtime change
  • Android (example app) — not applicable, no runtime change

Checklist

  • yarn lint, yarn typecheck, and yarn test all pass.
  • Public API changes are documented — there are none.
  • Bridge changes keep all three sides in sync — no bridge change here.
  • CHANGELOG.md updated under ## [Unreleased] — N/A: this PR cuts
    the release, so the entries sit under ## [1.2.1] - 2026-10-09.
  • I did not bump the version — N/A: this is the bump.
    Merging does not publish; pushing the v1.2.1 tag does.

After merging, see After publishing in docs/VERSION-UPDATE.md: the published
Snack needs its pinned version raised by hand.

@JoshuaPariona JoshuaPariona reopened this Oct 10, 2026
@majornutcracker-dev
majornutcracker-dev merged commit 531f265 into main Oct 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants