Conversation
Replaces a value re-export/import of a type-only entity so the esbuild-based Vite build can bundle it, and rebuilds the Vue dist files with the new toolchain.
Companion to matomo-org/matomo DEV-20451. The new accurate archiver backfills time_spent via visit_last_action_time, so sum_time_spent and avg_time_on_page shift for last-pageview rows; the interim nb_hits_with_time_spent metric has been dropped in favor of the existing nb_hits divisor.
# Conflicts: # vue/dist/CustomVariables.umd.js # vue/dist/CustomVariables.umd.min.js
…time The core writer now closes pageviews at the next in-visit action (closePreviousPageView), so log_page_view_time.time_spent reflects real wall-clock time rather than the legacy walk-forward sum. Live visitor log timeSpent updates accordingly (1620s -> 360s for the ManyVisitsWithGeoIP pageview at t+1h).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion submodule PR for matomo-org/matomo#24788 — updates the checked-in expected fixture(s) so they match the new accurate per-pageview time-on-page output.
Checklist