Count the answers that were refused and the changes that would not apply - #508
Open
bjmeetsfo wants to merge 2 commits into
Open
Count the answers that were refused and the changes that would not apply#508bjmeetsfo wants to merge 2 commits into
bjmeetsfo wants to merge 2 commits into
Conversation
Two things the metaserver does can fail without anything saying so. A topology query can be answered with an error: the table is gone, or frozen, or was never there. The request counter counts that as a query like any other, so a client looping against a name that does not exist looks exactly like one being served. A recorded mutation can fail to apply. That is the more serious of the two. Applying is how replay rebuilds the state from the log, so a mutation that will not apply means the recorded history and the state it should have produced have parted company -- and the metaserver carries on without mentioning it. That is the kind of thing that is only ever noticed later, from the wrong end. temporalstore_meta_topology_query_failed_total and temporalstore_meta_mutation_apply_failed_total. Counted around the whole answer and the whole apply, so every refusal reaches them however the call returns. Test: a query for a table that is not there, and dropping a table that was never created, each move their counter once; an answer that succeeds moves neither. Removing the apply counter fails it.
# Conflicts: # crates/temporalstore-rust/src/meta.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things the metaserver does can fail without anything saying so.
A topology query can be answered with an error: the table is gone, or
frozen, or was never there. The request counter counts that as a query like
any other, so a client looping against a name that does not exist looks
exactly like one being served.
A recorded mutation can fail to apply. That is the more serious of the two.
Applying is how replay rebuilds the state from the log, so a mutation that
will not apply means the recorded history and the state it should have
produced have parted company -- and the metaserver carries on without
mentioning it. That is the kind of thing that is only ever noticed later,
from the wrong end.
temporalstore_meta_topology_query_failed_total and
temporalstore_meta_mutation_apply_failed_total.
Counted around the whole answer and the whole apply, so every refusal
reaches them however the call returns.
Test: a query for a table that is not there, and dropping a table that was
never created, each move their counter once; an answer that succeeds moves
neither. Removing the apply counter fails it.