Apply document formatting to Tag conversion inputs - #278
Closed
be-student wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #209.
Apply the existing document conversion hook when
convert_soup()receives an individualTag. Previouslystrip_documentonly ran for a BeautifulSoup[document]node, so Tag inputs retained separation newlines and skipped option validation. Keep the hook running exactly once and honor existing converter exclusions.Validation: three new regression tests fail before the fix; all 87 tests pass afterward. Coverage includes all stripping modes across several root tags, internal paragraph spacing, custom hooks, invalid options, exclusions, and preservation of the source tree. Flake8, README reStructuredText lint, and diff checks pass on Python 3.12/macOS.