Keep transaction ids monotonic across process restarts - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
colossal-squuidkeeps its monotonic state in memory. After a process restart, or when the clock moves backwards, it can generate a transaction id below the latest id already stored by dbval.Because dbval uses transaction-id ordering to determine the current datom, such a transaction could commit successfully while its update remained invisible. The database basis also stayed at the older, higher transaction id.
The persisted database basis is the source of truth, so every new transaction id must be strictly greater than it.
Verification
script/test_clj.sh— 172 tests, 1079 assertions, 0 failurescd store-slatedb && clojure -M:test— 2 tests, 11 assertions, 0 failures