Repository navigation
Fix code-review issues and implement the backlog-batch plan - #171
Merged
Merged
Conversation
…boundaries when merging
…tead of assuming 1 fps
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
…d frame-size guard in the backlog-batch plan Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
…e is no background image Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
…s count Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
… SLEAP Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
…y Dataset Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
… its limit) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
… files Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
…mpty slots Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
…(GL-18) and 3-D cohesion (GL-19) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
…tes up to date Re-measured test and metric counts; reassigned the old D-11, D-12 and GL-16 proposals to D-17, D-18 and GL-20 (the originals are now shipped metric IDs); added anipose and deeplabcut_3d rows; trx.mat is built, synthetic only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
mbel-tech
changed the title
…ords none Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
mbel-tech
marked this pull request as ready for review
October 16, 2026 06:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by great salmon scientist · project thread
Before: A deep code review found 15 bugs (bypassable pickle allowlist, wrong Z-5 exits, stale cache key, broken binned exports, silent fps=1.0 fallback, UI, metadata, panel, zone and project-store problems), and
docs/superpowers/plans/2026-10-13-backlog-batch.mdwas unimplemented.After: Each bug is fixed with a test, and the plan is implemented except Tasks 0 (tag v0.3.0) and 12 (multi-animal Anipose), which wait on the user. Last full local run: 4769 passed, 219 skipped; ruff clean.
Review fixes, one commit each: idtrackerai unpickler allowlist, Z-5 gap exits, cache key, binned exports, v5 fps, DLC identity flags, calibration units,
run --workers, export overwrite guard, metadata numeric keys, empty panels, zones CSV round-trip, video overrides.Plan work:
add --reader)..h5(deeplabcut_h5, synthetic only; the real EPM file could not be downloaded here).movement/xarray adapter.Behaviour changes worth a look:
apply_panelraises on an empty panel; a v5 session with no readable fps fails at import; zones CSV gains optional columns; IL-3 and IL-14 are skipped on a declared side view.Not done: ticking the 339 plan checkboxes,
docs/IDTRACKERAI_FORMAT_ANALYSIS.mdgap table, regenerating the guide screenshot and PDF, andtrack_wo_identitiesfor the Ctrax and trx readers.🤖 Generated with Claude Code
https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
Generated by Claude Code