Repository navigation
Fix the last Windows golden test (manifest JSON bytes) - #174
Merged
Merged
Conversation
The manifest JSON writes a Windows path with escaped backslashes, so the byte-exact golden hashes only held on posix. Fold them to forward slashes before hashing; posix bytes are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
mbel-tech
marked this pull request as ready for review
October 16, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: after #173 the project-hash tests pass on Windows, but one test still fails there: it hashes the manifest's JSON bytes, and a Windows path is written with escaped backslashes (
\\data\\s1), so the golden sha256 differs.After: the test folds escaped backslashes to forward slashes before hashing. Posix bytes are unchanged (the test passes locally), and nothing in the product code changes.
How: a small
_posixhelper intests/test_native3d/test_pixel_unchanged.py. The Windows jobs run only on main, so this can only be confirmed there after the merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01N7hYfMaQFqSMBtq9ZWJ3gV
Generated by Claude Code