Repository navigation
Isolate executor diagnostics and query download support - #1035
Merged
Merged
Conversation
helly25
marked this pull request as ready for review
November 1, 2026 10:17
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep executor experiments reproducible without changing xff's scheduling behavior. This gathers the query download repair and standalone executor diagnostic into one infrastructure change, so runtime proposals can be evaluated independently.
AG;DR
RunExecutorimplementation is retained as a privatetestonlysupport library; the measurement library and executable are alsotestonly. Production targets cannot depend on these libraries, and traversal/content/comparison implementations are untouched.Dependencies: based directly on main; no dependency on runtime PRs #991, #992, #996, #997, #998 or #1001. The experimental support source originated in that stack but has no shipping integration here. No merge or runtime acceptance is requested.
Historical validation of pushed head
43d7828dc2acd8dbcd9f735200877542db72c47fon macOS ARM64 with hermetic LLVM 23.1.4:run_executor_testandexecutor_measurement_testpassed; the release diagnostic built;leaf,claimableanddraineach returned the independent expected checksum 4290 for 130 processed items (65 items, two sweeps, zero mixing).bazel query 'somepath(//xff:xff, //xff/engine:run_executor_cc)'returned no path. Repository-tooling tests (6) and normal commit/push hooks passed. Linux x86-64 on drogon also passed both executor test targets against this pushed head. Both platforms built the shipping release CLI with--config=clang_releaseand returned no dependency path from//xff/cli:xffto the experimental executor. Linux CLI SHA256 is byte-for-byte identical to the baseline (021f1598136e0162b4a7f4658b77795d3802b6be61ba71994e2b7676843cc042). macOS CLI__TEXT,__textis identical (2,032,340 bytes; SHA25667cb6471abbef3aa28e7c29fd4e9e9305a68464824cfc98b51ac2b9f2ddbcc30); all 14 non-debug Mach-O sections are identical, including constants and strings; whole Mach-O hashes differ in metadata/link-edit payloads (file sizes 4,064,320 vs 4,064,448 bytes). Actual local clang-tidy passed all five new translation units using target-scoped compile commands with hermetic LLVM 23. That original head completed all 32 reported check contexts successfully or skipped, including the finaldoneaggregate. The initial Ubuntu-latest attempt ran out of runner disk while extracting the unchanged LLVM archive before C++ compilation; one targeted retry succeeded (run41292713084, attempt 2), preserving the other successful contexts. That retry did not change the head. Subsequently, the user explicitly requested synchronization with current main; the clean merge was immediately pushed asb830e17874including mainb68a9c3a58(#1036/#1038 uploader tooling). Normal synchronization push hooks passed. Replacement current-head CI run41303081236completed successfully onb830e17874, including both default platform suites, all sanitizers, clang-tidy, benchmark measurements/comparison and finaldoneaggregate. The earlier binary-isolation/test evidence remains historical and is distinguished from this new PR context. GitHub recognizes the unchanged head and current base; the PR remains ready for review only, without approval, merge or auto-merge.Limitations: synthetic phase timings include bookkeeping and do not establish full-engine performance or native storage behavior. The probe is portable C++/Abseil, but sanitizer checks and full-workload measurements remain required before making new performance claims.