Repository navigation
Render lexical filename fields from borrowed path slices - #1044
Merged
Merged
Conversation
helly25
force-pushed
the
perf/lexical-field-views
branch
from
November 2, 2026 01:36
f7fea20 to
2e981dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render filename, stem and extension fields directly from borrowed input slices instead of constructing temporary path objects. Multi-field output improves on both hosts while preserving native directory spelling and the existing output.
AG;DR
docs/performance-analysis.md/TODO.mdinventory. Uses existingStringOrView; no new path wrapper, per-entry cache, thread pool, option or dependency.parent_pathfor directory fields and qualifiers because repeated-separator normalization is observable. Consume borrowed component views while input/owned field values remain alive.Evidence:
docs/benchmarks/lexical-field-views-20261102.mdand three lossless archives retain source/binary identities, scripts, every raw sample, exact native output oracles and slower controls.Validation:
Synchronization: head
2e981dd390rebases onto merged #1043/main9e4338a6ea. All four tracking-file conflicts preserve both changes. Field runtime/test sources remain unchanged. Normal enforcing push hooks pass, including the inherited fuzzy compilation scope. Earlier full-suite and benchmark evidence uses its recorded parent; all eight combined post-sync targets pass on both hosts, and all required replacement PR checks pass on this head, including coverage, sanitizers, clang-tidy, platform tests and benchmark aggregation.