Repository navigation
Reuse budgeted native comparison cursor buffers - #1047
Merged
Merged
Conversation
helly25
force-pushed
the
perf/cursor-owned-read-buffers
branch
from
November 2, 2026 04:26
cdaae0e to
d2ff56b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse native comparison buffers across file chunks, reducing allocation traffic and making large complete comparisons faster on macOS and Linux. Keep existing archive and decoder behavior and source-budget limits.
AG;DR
docs/performance-analysis.mdandTODO.md; Avoid redundant zeroing in native bounded range reads #1046 is merged. Replayed the single O07 commit onto current main7c0f507f7c815146a9b746e40269377dbc768b37and immediately pushed synchronization. Git reports no tree difference from the qualified pre-squash head; required CI now runs in the main-base context. Evidence retains the exact original measurement parent rather than relabeling old samples.ReadStream::ReadInto(span<char>)capability. Only the read-only host adapter opts in. Unsupported streams neither allocate/copy nor consume input. The existing owning Read interface remains unchanged.Evidence and limits:
docs/benchmarks/cursor-owned-read-buffers-20261102.mdpublishes initial/refined variants, all raw native and fallback samples, source/binary hashes, scripts and allocation-control logs/XML. Source snapshots match the measured production implementation.Validation: