Repository navigation
Pack owned matcher and deferred entry text - #1049
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pack pending matcher and deferred-entry text into one owned buffer, reducing allocation traffic while preserving entry lifetimes and ordered output. Long overlapping snapshots use about two-thirds fewer allocation calls; native elapsed gains are modest and vary by workload.
AG;DR
Implementation and ownership
OwnedVisit: one owned byte string plus offsets for path, basename and root. Exact suffix/prefix ranges share bytes; independent values append to the same allocation. Resolve views against the current string so short-string moves and vector relocation remain safe.emplace_back. Keep the existing vector-consumption/ordered-result protocol and worker admission policy.Measurements and decisions
Decision report and lossless evidence retain all source variants, raw repetitions, fixtures, executable/source hashes, scripts, allocation counters and qualification logs on this macOS host and Linux
drogon.The initial qualification-only driver rotated participants and reversed odd rounds, which cancels rotation for two variants. Preserve those populations explicitly; corrected rotation-only confirmation repeats 32 representative cases with three sessions, nine rounds/fastest seven and independent per-invocation output oracles on each host. The published benchmark runner already uses rotation without reversal and is unaffected.
TODO.mdrecords the retrospective audit of older two-variant qualification scripts.Validation and portability
The evidence archive has a narrowly scoped large-file-hook exception alongside the existing qualification reports; the normal archive-ignore rule requires explicitly staging this intended artifact. Documentation, the release-site mapping,
CHANGELOG.md, and the O09/TODO tracking are updated together.Based on merged #1048. The measured parent
5ca865a453acba2437909ec489c528b989bdf315and merged main7cf2a52441d626888b5840d09a4646d6dedca6b9have identical trees; the unpublished branch was synchronized before committing. O10 bounded result-capacity reuse remains separate.