Repository navigation
Aggregate ordinary comparison side totals directly - #1057
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary comparison summaries now build left and right totals directly, reducing duplicate per-path summary storage. Category summaries and expressions with actions retain their existing behavior.
AG;DR
Based on main after #1056 merged. Synchronization head
ae7ec80094471b0d1d94f9aa654d1ffc13741d94contains mainfc2cd316e81d7319aa44912e786e7aad4492cd0a; its complete tree is identical to measured headcc00b95f0842dc8a07f7d936f12badde5f6af85f. Normal synchronization commit/push hooks pass; required CI is running on the current pushed head.Implementation:
overall,typeandextsummaries with no category scope, reuse per-root aggregates to construct side-total columns instead of allocating summary vectors/maps under every path and rebuilding the same totals through a category map.Evidence and tradeoffs:
docs/benchmarks/aggregate-comparison-totals-20261102.mdand compressed raw data retain source/compiler/build/link/binary identities, all samples, scripts, setup failures and validation logs.Validation:
Update the canonical performance analysis, TODO, summary design, changelog and release-site mapping. Preserve broader expression, concurrency, archive, metadata, similarity and output work as open rather than claiming it complete from this narrower optimization.