Repository navigation
Borrow cached digests and streamline output records - #1067
Merged
Merged
Conversation
…nto perf/borrow-normalized-shingles
…nto perf/borrow-normalized-shingles
… into perf/borrow-output-values
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached hash values now reach actions and fields without temporary string copies. Plain records use their final storage directly, and escaped output copies printable runs in bulk. This reduces allocation churn and improves repeated hash-field workloads on both macOS and Linux.
AG;DR
Dependency and merge order: #1066 is merged; this PR is synchronized directly onto
main. #1068 is the dependent follow-up. The synchronization preserves all runtime/test code and dependency updates; it also fixes the concrete CI deadline below. The cross-platform measurements below predate #1065 and remain historical qualification; this PR’s current-head CI verifies the synchronized configuration.Implementation and ownership:
Snapshot::DigestViewborrows stable cached map-node bytes; the owningDigestAPI remains available. Invalidation, transfer, moving and destruction end the public borrow contract.Qualification:
docs/benchmarks/digest-and-record-storage-20261103.mdlinks exact lossless source/configuration, all populations, slower controls, diagnostics, correctness logs and rejected prototype evidence. The first combined prototype regressed escaped Linux records and was rejected. Its complete Linux evidence, full Mac native matrix and explicitly partial Mac memory population remain separate; obsolete Mac prototype work was intentionally stopped rather than claiming full validation. The revised bulk-append candidate received full qualification on both hosts.Real scoped clang-tidy passed on both hosts, including the header-selected Mac consumers and failed-file refinements. Normal enforcing commit/push hooks and this PR’s current-head CI determine readiness; local qualification does not replace those checks. The changelog, performance analysis, TODO subitems, manual benchmark indexing and release-site report mapping are included.
CI deadline recovery: