Repository navigation
Skip discarded archive payloads through bounded owned cursors - #1071
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advance eligible owned cursors over discarded archive payloads instead of reading every byte. This makes listing large uncompressed archives and reaching later members substantially faster while preserving sequential fallbacks, selected content, errors and shared read budgets.
AG;DR
Dependency #1070 is merged. This branch starts directly at current main
44e7e30102eb6c6ae122135189b6c62340c35bdb; its complete parent tree equals the qualification parent38ac542f621abd9fb2610e0d01f8646f42428ab3. The six candidate source files retain their exact verified bytes after synchronization. Fresh checks in this PR's own context determine readiness; earlier PR checks are not substituted.Implementation and resource contracts:
ReadStream::Skip: absence means unsupported without consuming input; a present count advances the existing cursor, may be short, and must not exceed the request. Zero alone is not EOF. Existing Read/ReadInto remain available and share the same position.Verification:
f68cfa09c944da83946c66fd185ea579ab2876b5, including formatting, header-consumer clang-tidy and Trunk. Fresh current-head CI remains required. Qualification retains initial failures and final successful logs separately.Performance and costs:
Documentation and retained work:
docs/benchmarks/forward-cursor-skipping-20261103.md.b66c5d4a2785e9d4659314293b1ffd5545459d6c379a9e70bc54691d2f309461. It retains sources, scripts, compiler/configuration/link/binary identities, raw timings, independent oracles, validation/coverage logs and exact parent synchronization proof.