Repository navigation
Skip obsolete queued benchmark previews before loading the site - #1137
Merged
Merged
Conversation
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop obsolete PR benchmark previews from loading and processing the complete retained site after a long queue wait. Recheck freshness inside the writer job, and use collection's final result before setting up the renderer or publishing.
AG;DR
A preview's comparison waiter can succeed while its PR head is current, then spend hours waiting for the shared writer lock. The existing collector correctly returns no data for the superseded head, but the workflow still expanded retained inputs, built the renderer, refreshed/compacted reports, and attempted an unchanged push. One observed publisher reported zero decorated pages and no branch changes after substantial preparation work.
currentoperation to the trusted preview helper, using the existing source-attempt, Test/PR-event, repository, open-PR, and current-head validation. It needs source identity but no retained-site root or artifact listing.Validation: 82 direct regression tests passed on both macOS and Linux over SSH, with all 199 transferred source hashes checked. All five affected Mac Bazel targets passed; the final API-failure regression was also executed in the hermetic preview target. Tests cover current versus superseded attempts/heads, closed or foreign-repository PRs, no site/artifact access during the check, failure propagation, required arguments, placement after lock acquisition, and both admission-time and collection-time workflow guards. Normal pre-commit (local clang-tidy skipped under the standing instruction), actionlint, Trunk, and diff checks passed for all seven changed files. Public-head CI remains required.
This is a separate follow-up to #1135/#1136 and does not modify their heads. Fresh previews pay one additional bounded source/PR API check. No elapsed-time speedup is asserted. Already queued legacy workflow definitions retain their original steps; earlier queue-full source rejections still need recovery. Obsolete preview cleanup is deferred to the next normal metadata refresh, and a successful no-op producer can still send a notification to the coalesced latest-snapshot deployer. No incoming valid measurements are canceled or discarded.
Public integration and current qualification
#1135 and #1136 are merged. Current signed head
737795b2050af4f10d912e5322a41e2ed8fea618incorporates actual main1f25ba6d4ae0c9d69d6a2143940f08c2ed41acbe, including the template-stat runtime and all intervening reports. The normal combined merge resolves eight repeated-ancestry/context conflicts. It preserves the exact qualified preview helper (fcc75edb94a83b9b61c1cabd6878ceb53b8af96554f51ae19234e552cbd39b64) and its test source, the original stale-admission workflow conditions, every newer main implementation outside this seven-file delta, current fifth-candidate policy regressions, canonical documentation, exact evidence exemptions and site mappings. Combined tree:16a968ea59bc72999c619705369a337339a08984.Tables and diff checks pass; all 32 integrated workflow/history tests pass under Python 3.13. An initial old-default-Python import failure occurred before test execution and was resolved by using the installed supported interpreter, with the failure retained separately. Normal signed commit and immediate push hooks passed; normal merge hooks intentionally skip redundant Trunk, and no local clang-tidy ran. Fresh own current-main Test 42399241252 completed successfully on this actual pushed head, including every product/lint/sanitizer/coverage check, all six initial shards, the required fourth Mac candidate, agreement, final best-seven-of-nine comparison and
done; fifth candidates skipped normally after agreement. Exact predecessor-main Test 42398990563 also completed successfully. GitHub recognizes this head as current and mergeable; earlier stacked-head checks do not establish readiness.This is the remaining queue root, with #1138 as its immediate child. Merge this PR unchanged when ready, then synchronize the retargeted child. The first #1135 hosted deployment verified its live index, but missing-source replay, obsolete legacy queued definitions and broader retained-site storage/rendering work remain separate open items.