Repository navigation
Audit performance candidate completion and retain reserve trial - #1141
Merged
Merged
Conversation
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconcile the performance candidates without losing rejected implementations or treating a completed subset as the whole plan. Retain the exact language-list reservation trial as an unselected experiment; production behavior stays unchanged.
AG;DR
77aa9ef9and the separately published follow-ups. Document actual remaining pipeline, archive, catalog, representation and integration requirements; keep the full goal active.No final runtime/full-suite/sanitizer/local clang-tidy/production binary/ThinLTO/startup or whole-command speedup claim is made by this rejection screen. The new audit itself does not independently rerun every historical benchmark or prove completion of the active goal.
Dependency and public integration validation
This is a documentation-only child of #1140 (
ac4e69b2f434126ca17fb500322c181565f92c41), preserving every earlier public report, map and exact evidence exception. The frozen reservation report and capsule hashes remain exact; the audit links are corrected as detailed below. Integrated release-site tests passed 32/32; all normal signed commit hooks and Trunk passed for the seven changed files. Local clang-tidy was explicitly skipped. This pushed PR must pass its own required CI; earlier experimental/private or parent checks are not readiness. The audit records an explicit main-77aa snapshot; GitHub and the ignored orchestration ledger govern the moving graph. No runtime, BUILD rule, temporary driver or allocation/RSS/startup claim is added.Actual CI correction
The initial pushed head failed the full release-site build because two relative audit links referenced reports from the other unmerged chain (#1131/#1132). Signed correction
1dfd581c2ffc1ba25d61cb8eb22e6b8ab0158f14pins only those links to the already-published immutable report commits; table spacing follows the required formatter. All 22 audit links now pass the actual release-siteLinks.rewriteimplementation locally, and the pinned report Git objects were verified. The reservation report and evidence capsule are unchanged. Normal correction commit/push hooks and Trunk passed; no local clang-tidy or unpublished Markdown API preview ran. Fresh own-head CI remains required; initial failed CI is retained, not relabeled.Synchronization after #1140 and #1144
#1140 merged as
50fe2426d690156e5c388eb879b6295c4e123801; #1144's native-case symlink fix is also on main. Merge commit2a0e828c19be5655546971b4b34d884f3fcde14dresolves the six stacked integration conflicts while preserving all current-main documentation and mappings and this PR's seven-file audit/evidence payload. Both original language experiment reports and all 13,361 individual capsule records remain byte-identical and their length/SHA-256 hashes were checked. Normal merge commit and push hooks passed. Fresh current-main Test CI and repeat measurements are pending; the historical experiment remains labeled with its original source and images.Fresh current-main remeasurement
Commit
ec2f900572912046942b036229d8a471c6bf2cf8retains a separate complete repeat of the original language-list reservation trial on main50fe2426d690156e5c388eb879b6295c4e123801. Three sessions per host cover all 16 cases, 1,296 timed observations and 144 warmups per host; every raw observation, fastest-seven mean and ratio was independently recomputed. All 4,345 transferred Linux files and all 8,680 capsule records passed length/SHA-256 verification. Baseline, candidate, harness and driver are identical across hosts; binary hashes and exact-image controls are retained.The full linked cold snapshot improves 0.909% macOS / 0.420% Linux; cold catalog changes -0.483% / +0.296%. Linux 8-language lists with zero or one value cost +1.694%/+1.892%; the 128-language empty case costs +1.683% (copy -0.827%). The lean macOS cold snapshot costs +4.718% (copy +2.226%). Complete case and control results are in
docs/benchmarks/language-list-reserve-requalification-20261108.md. No practical command-level gain is established, so keep the reservation prototype unselected; this PR retains the audit and evidence without production runtime changes.The 542,618-byte lossless capsule SHA-256 is
7ecdc251f181d979cc1ca839f725dc25343027588bca740923d895e4b82205fc. All 32 release-site tests passed locally, and normal commit hooks passed. Final pushed-head CI remains required.