chore: dead-code sweep 2026-07-27 — drop unused export modifier on SubscribeSourceFactory - #155
Open
mbret wants to merge 1 commit into
Open
chore: dead-code sweep 2026-07-27 — drop unused export modifier on SubscribeSourceFactory#155mbret wants to merge 1 commit into
mbret wants to merge 1 commit into
Conversation
The type is only referenced by SubscribeSource within the same file; nothing imports it and the useSubscribe barrel does not re-export types.ts, so the export was dead surface. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R9ch8GmdfsE2RPy8adBGPo
Owner
Author
|
CI is red on Check, but the failure is a pre-existing flaky test, not this PR: Evidence it's unrelated to this diff:
I've re-run the failed job; given the observed ~25–30% failure rate it should go green within a retry or two. The test's own comment ("interval big enough so react does not skip some render") hints at the hazard — it may be worth deflaking separately, but that's out of scope for a dead-code sweep. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated strict dead-code sweep (knip over library + dev entries, plus a production-entries-only pass, every candidate verified by repo-wide grep).
Removed
exportmodifier onSubscribeSourceFactory(src/lib/binding/useSubscribe/types.ts) — the type itself is live (used bySubscribeSourcein the same file), but the export was dead surface. Evidence: repo-wide grep forSubscribeSourceFactorymatches only its own declaration and the same-fileSubscribeSourcereference;src/lib/binding/useSubscribe/index.tsre-exports only./useSubscribe, not./types, so the type never reaches the package's public API viasrc/index.ts.Candidates investigated and kept
src/lib/state/persistence/adapters/MockAdapter.ts— flagged unused in production-only analysis, but it is live test infrastructure imported bypersistSignals.test.ts.src/lib/utils/filterObjectByKey.ts— same situation: imported byuseObserve.selector.test.tsxas a test helper.No unused files, no unused package dependencies found. Public API exported through
src/index.tswas treated as off-limits (published npm package).Gates
Baseline on clean
mainand after the change, both fully green:npm run check(biome) ✓npm run build(tsc + vite) ✓npm run test:ci— 23 files, 134 tests ✓🤖 Generated with Claude Code
https://claude.ai/code/session_01R9ch8GmdfsE2RPy8adBGPo
Generated by Claude Code