Repository navigation
test(webui): the agent transcript names the browser panel's state when no frame arrives - #34
Merged
Merged
Conversation
…n no frame arrives The browser panel has six states, each with its own testid. The diagnostic looked at two of them, and those two read the same in every failure: the empty placeholder is on screen whether the stream is slow, whether the stream failed, or whether the host cannot serve a browser at all. The product's own first-frame deadline is 60s -- the same budget the wait had -- so a panel that had already given up used to look exactly like a panel that was merely slow, and the failure could not tell the two apart. The wait now ends on whichever comes first: the frame, or the panel's own failure notice. A failure prints every browser-panel node that was on the page, with the browser's error code beside the notice's words, so the next occurrence says which state the panel was in. The budget is unchanged: 60s, and the wait never outlasts it. No expected value changed, no retry was added, no case was skipped.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The agent-transcript integration case waits for the browser panel's first frame, and when the frame never arrives the failure has to say what the panel was doing. It could not.
The panel has six states, each carrying its own testid (
packages/webui/src/client/features/browser/ui/BrowserPanel.public.tsx). The diagnostic looked at two of them -- the empty placeholder and the capability notices -- and both read the same in every failure: the placeholder is on screen whether the stream is slow, whether the stream failed, or whether the host cannot serve a browser at all. The product's own first-frame deadline is 60 seconds (packages/webui/src/runtime/browser/browser-service.ts), the same budget the wait had, so a panel that had already given up used to look exactly like a panel that was merely slow.The wait now ends on whichever comes first: the frame, or the panel's own failure notice. A failure prints every
browser-panel-*node that was on the page, with the browser's error code beside the notice's words, so the next occurrence names the state instead of guessing at it.This is the readable-failure half of #32. It does not change what the product does, and it does not change what the test asserts: the frame still has to arrive.
Validation
pnpm --filter @mavis/webui typecheck:test: pass.perf:fulllabel: the change is outside the paths the performance rules inCONTRIBUTING.mdlist, and it is not a performance optimization..github/workflows/webui-ci.ymlandplaywright.config.mjs), outside this change, and is still open.Publication and contribution checks
release/public-source.json; new tests are declared intest/vitest-suites.jsonwhere applicable. -- no source file was added or removed, sorelease/public-source.jsonis unchanged; no vitest file was added, so no suite declaration is needed.Maintainer handoff
Publication scope or license changes (if any): none.
Shared-source port: not needed. The change is inside
packages/webui, which does not exist upstream; perpackages/webui/docs/agents/issue-tracker.mdnothing in this repository is published to upstream.