Repository navigation
test(webui): re-record the darwin and win32 baselines after the UI changed - #38
Merged
Merged
Conversation
…anged PR #36 re-recorded the Linux baselines only, so the darwin and win32 baselines still hold the picture from before that change. On macOS and Windows the pixel gate now fails on 15 shots each: the four plugin catalogue forms, the shell and the workspace panel at 1440, 1280, 1024, 900 and 768, and the shell rail, the transcript and the progress panel. The 30 new baselines are the actual images of run 42998849283, the run that failed. A baseline recorded on another machine is that machine's rasteriser's idea of the same picture, and the runner that compares it would fail it, so the images have to come from the runner itself. What the new baselines show is the change PR #36 made. The progress panel is 288 by 139 pixels now and was 288 by 281: its sections size to their content instead of holding a fixed 200 pixels. Every other shot moves by the same few pixels: 1578 on the four dialogues and 2126 on the eleven shells, rails and transcripts on darwin, 1644 and 2204 on win32. That is 0.12% to 0.32% of the picture, and the count is the same across the shots because the same rail rows and the same lines of dialogue text are what moved. The platforms also agree with each other better than they did before. The gap between the darwin and the linux picture was 0.31% to 0.68% of the image and is 0.20% to 0.47% now; on win32 it was 0.30% to 0.68% and is 0.21% to 0.48%. What is left is anti-aliasing rather than a different layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The macOS and Windows pixel gates fail on 15 shots each after PR #36, because that pull request re-recorded the Linux baselines only and the darwin and win32 baselines still hold the picture from before the UI changed.
This pull request re-records the 30 stale baselines: the four plugin catalogue forms, the shell and the workspace panel at 1440, 1280, 1024, 900 and 768, and the shell rail, the transcript and the progress panel, for darwin and for win32.
The images are the actual images of run 42998849283, the run that failed. A baseline recorded on any other machine is that machine's rasteriser's idea of the same picture, and the runner that compares it would fail it, so the images have to come from the runner itself.
Validation
magick compare -metric AEover the old and the new file of each shot; the ratio is printed in parentheses next to the pixel count.perf:fullrun: this pull request replaces test images and touches no product code.Publication and contribution checks
release/public-source.json; new tests are declared intest/vitest-suites.jsonwhere applicable. No source file and no test file was added or removed: only 30 baseline images underpackages/webui/test/browser/were replaced, so neither registry changes.Maintainer handoff
Publication scope or license changes (if any): none.
Shared-source port: not needed. Record public PR references only; keep private links and review material out of this PR.