fix(tooling): harden project regression checks - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the existing RFC-0090 compile and metric-result tooling without expanding its scope:
Validation
make check— passedmake docs-check,make fmt-check,git diff --check— passedCGO_ENABLED=1 go test -tags duckdb ./cmd/metis ./app/tooling/regression -count=1— passedGORACE=atexit_sleep_ms=0 CGO_ENABLED=1 go test -race ./app/tooling/regression ./cmd/metis -count=1— passedThe initial full-package race run with default exit sleep hit the existing stdio subprocess test's one-second termination window (
signal: terminated). It did not report a data race. Disabling the detector's exit sleep lets that full run pass; no stdio code or test was changed.Compatibility
No new commands, analytical assertions, public query types, or benchmark changes. Previously accepted lossy/ambiguous numeric inputs now fail before execution.
--overwriteremains available for existing Metis reports but no longer authorizes replacing unrelated files. Error-report fields gain safe diagnostic values without changing schema version or outcome counting.