Repository navigation
fix(release-candidate): allow hotfix from the latest tag - #49
Merged
Troublor merged 1 commit intoSep 30, 2026
Merged
Conversation
Settlement leaves v* tags off trunk, so a patch of the current release could not be named as base_commit. Accept commits on the latest release line; keep refusing unrelated side branches.
Troublor
deleted the
mega-putin/fix/release-candidate-hotfix-from-latest-tag
branch
September 30, 2026 00:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
release-candidatebase_committo start a hotfix of the latestv*tag, not only a commit that is already an ancestor of the default branch.Settlement leaves the tag off trunk (version bump + dated changelog). That is why
mega-rethv2.2.1(7d0dbf3) is refused today even though its parent is ondevelop.Two flows stay as they are:
base_commit: candidate PR against the default branch, thencutcreatesrelease-vX.Y.Z.base_commit: cutrelease-vX.Y.Zat that commit first, then the candidate PR targets that branch.What changed
[merge-base(latest v* tag, default branch), latest v* tag].v*tag, and those commits are outside the window.Test plan
actions-test.yml: latest tagv1.0.0is an allowedbase_commit; unreachable side commit and nonsense SHA still refusedaction_docs.py --check