MFEM 4.9.1 prep - #316
Conversation
|
Made PR to trigger build test actions |
There was a problem hiding this comment.
🟡 Changes recommended
The new fe_pyramid extensions are built but not re-exported via the high-level mfem.ser / mfem.par convenience modules, and the Python version classifier change appears inconsistent with current CI coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Prepares PyMFEM for the 4.9.1 release by updating package metadata/versioning and adding new SWIG bindings for MFEM’s pyramid finite element header in both serial and parallel builds.
Changes:
- Add
fe_pyramidSWIG interface modules and wire them into the SWIG build lists for_serand_par. - Import the new SWIG interface from the existing
fe.iaggregation modules. - Update project metadata (Python classifiers) and bump
mfem.__version__to4.9.1, with a changelog entry.
File summaries
| File | Description |
|---|---|
| pyproject.toml | Updates supported-Python classifiers (adds 3.14, drops 3.9). |
| mfem/_ser/setup.py | Adds fe_pyramid to the serial extension build module list. |
| mfem/_ser/fe.i | Imports the new fe_pyramid.i interface into the serial FE aggregation. |
| mfem/_ser/fe_pyramid.i | New serial SWIG module wrapping fem/fe/fe_pyramid.hpp (guarded by header-exists macro). |
| mfem/_par/setup.py | Adds fe_pyramid to the parallel extension build module list. |
| mfem/_par/fe.i | Imports the new fe_pyramid.i interface into the parallel FE aggregation. |
| mfem/_par/fe_pyramid.i | New parallel SWIG module wrapping fem/fe/fe_pyramid.hpp (guarded by header-exists macro). |
| mfem/init.py | Bumps __version__ to 4.9.1. |
| docs/changelog.txt | Notes the addition of fe_pyramid.i. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 3
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This PR include
mfem::ParGridFunction::ProjectDiscCoefficient(std::variant<mfem::Coefficient*, mfem::VectorCoefficient*>)
which was introduced recently in pgridfunc.hpp