Repository navigation
fix(telescope): Show full locations and confirm from normal mode - #51
Merged
Merged
Conversation
The single-column entry_display layout dropped every chunk after the first, so entries showed only the symbol, or only the directory when there was no symbol. Entries now return the joined text with byte-range highlights directly, which is the contract Telescope resolves for entry.display, and the spec no longer relies on a mock that concatenated chunks unconditionally.
Only the insert-mode <CR> was routed to peekstack, so confirming after switching to normal mode fell through to Telescope's default edit and opened the file instead of a popup. Both modes now share the same selection callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<CR>in normal mode now opens a peekstack popup instead of falling through to Telescope's default editChanges
entry.display, instead of a single-columnentry_displaylayout that dropped every chunk after the first<CR>share the same selection callback, covered by the spec for both modes