Remove the superseded Stateright disaster recovery model - #8280
Merged
Conversation
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
2 times, most recently
from
September 4, 2026 22:12
2609b78 to
cb35a83
Compare
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 4, 2026 23:17
cb35a83 to
3403bce
Compare
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 7, 2026 20:02
3403bce to
d341941
Compare
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 8, 2026 09:58
eed41de to
f41cc8d
Compare
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 8, 2026 15:46
f41cc8d to
1f08f54
Compare
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 8, 2026 21:00
1f08f54 to
f0b819d
Compare
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 9, 2026 14:05
f0b819d to
2e82927
Compare
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 9, 2026 14:16
2e82927 to
3a1accc
Compare
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 9, 2026 17:15
3a1accc to
79cf6ae
Compare
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 9, 2026 17:31
79cf6ae to
f491105
Compare
Heidi Howard (heidihoward)
approved these changes
Sep 10, 2026
Copilot started reviewing on behalf of
Amaury Chamayou (achamayou)
September 10, 2026 10:53
View session
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It is explicitly gated on stacked-PR evidence and full migration CI results that cannot be verified from this diff alone.
Pull request overview
This PR removes the now-superseded legacy disaster recovery model and the temporary Lean/Rust migration-evidence layer, leaving the canonical Lean disaster recovery model as the single maintained source of verification in the repo. It also updates CI workflows and workflow documentation to drop the removed jobs and triggers.
Changes:
- Deletes the legacy Rust/Stateright disaster recovery model project under
tla/disaster-recovery/. - Deletes the temporary Lean migration evidence package under
lean/disaster-recovery-migration/. - Removes the associated GitHub Actions jobs/triggers and updates workflow documentation accordingly.
Custom instructions used
None (no additional repository instruction files were loaded via tools).
File summaries
| File | Description |
|---|---|
tla/disaster-recovery/src/model.rs |
Removed legacy Stateright actor/model implementation. |
tla/disaster-recovery/src/main.rs |
Removed legacy CLI (check/serve/export) entrypoint. |
tla/disaster-recovery/src/export.rs |
Removed legacy canonical graph exporter implementation. |
tla/disaster-recovery/Readme.md |
Removed documentation for the legacy Stateright model and exporter format. |
tla/disaster-recovery/Cargo.toml |
Removed legacy Rust crate manifest. |
tla/disaster-recovery/Cargo.lock |
Removed legacy Rust dependency lockfile. |
tla/disaster-recovery/.gitignore |
Removed legacy Rust build ignore rules (project deleted). |
lean/disaster-recovery-migration/Tests.lean |
Removed temporary semantic checks for the migration mirror. |
lean/disaster-recovery-migration/README.md |
Removed temporary migration package documentation. |
lean/disaster-recovery-migration/Main.lean |
Removed temporary migration model-checker executable entrypoint. |
lean/disaster-recovery-migration/lean-toolchain |
Removed pinned Lean toolchain for the temporary migration package. |
lean/disaster-recovery-migration/lakefile.toml |
Removed Lake configuration for the temporary migration package. |
lean/disaster-recovery-migration/lake-manifest.json |
Removed Lake manifest for the temporary migration package. |
lean/disaster-recovery-migration/ExportMain.lean |
Removed temporary migration exporter executable entrypoint. |
lean/disaster-recovery-migration/DisasterRecoveryMigration/Refinement.lean |
Removed temporary phase-refinement proof layer (bridge). |
lean/disaster-recovery-migration/DisasterRecoveryMigration/Legacy/Model.lean |
Removed Lean mirror of the legacy model (temporary bridge). |
lean/disaster-recovery-migration/DisasterRecoveryMigration/Legacy/Checker.lean |
Removed temporary Lean BFS checker/exporter for legacy mirror. |
lean/disaster-recovery-migration/DisasterRecoveryMigration.lean |
Removed migration package root module. |
lean/disaster-recovery-migration/compare.py |
Removed Rust/Lean exhaustive graph comparison script (temporary evidence). |
.github/workflows/README.md |
Updated workflow documentation to drop references to removed DR migration/evidence jobs. |
.github/workflows/lean.yml |
Removed migration-evidence job and the tla/disaster-recovery/** PR path trigger; retains canonical Lean checks. |
.github/workflows/ci-verification.yml |
Removed the Self-Healing Open model-checking job which depended on the deleted legacy project. |
Review details
- Files reviewed: 21/22 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Amaury Chamayou (achamayou)
force-pushed
the
achamayou-solid-tribble
branch
from
September 11, 2026 13:05
52cc367 to
35b7220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack status
This is part 3/4 of the disaster recovery verification stack. Part 1, #8277, is merged. This PR is stacked on the open part 2, #8279, at commit
2e39b3108127bee3576e83ec0c5345d2bb723096.The
Temporary migration evidencecheck passed on that exact #8279 commit, including exhaustive Rust/Lean graph comparison for one, two, and three nodes. If the predecessor head changes, that evidence must pass again on the new head before this PR merges.Summary
This PR removes the temporary migration evidence after #8279 established two deliberately different results:
Changes
lean/disaster-recovery-migration/package.tla/disaster-recovery/Rust/Stateright project, including its temporary graph exporter.migration-evidencejob and the deleted Stateright path trigger from.github/workflows/lean.yml.model-checking-self-healing-openjob from.github/workflows/ci-verification.yml..github/workflows/README.mdto describe the remaining workflows.The shared
.github/workflows/lean.ymlremains the repository's single Lean workflow. Its permanent canonical disaster recovery job runs on relevant pull requests. A proposed weekly trigger was removed after review because the toolchain and dependencies are pinned and this workflow performs no external trace validation.Canonical model unchanged
There is no diff under
lean/disaster-recovery/from the current #8279 head. This PR does not alter the canonical model, proofs, executable checks, or package metadata validated by the predecessor.Validation
lake exe mk_all --check --lib DisasterRecoverylake build --wfaillake lintlake exe canonical-checksscripts/prettier-checks.shscripts/ascii-checks.shlean/disaster-recovery/Part 4, #8282, adds C++ trace emission and Lean trace replay under
lean/disaster-recovery-trace/.