Skip to content

Include partition tests in coverage workflow - #8321

Open
Amaury Chamayou (achamayou) wants to merge 2 commits into
mainfrom
achamayou-partition-coverage
Open

Include partition tests in coverage workflow#8321
Amaury Chamayou (achamayou) wants to merge 2 commits into
mainfrom
achamayou-partition-coverage

Conversation

@achamayou

@achamayou Amaury Chamayou (achamayou) commented Sep 9, 2026

Copy link
Copy Markdown
Member

Run the existing partition suite before coverage aggregation; other tests and reporting are unchanged.

cd build
./tests.sh --timeout 360 --output-on-failure -C partitions -L '^partitions$' --no-tests=error

-C partitions is required by CTest registration. The motivating coverage run omitted this suite.

Validation: Workflow checks and profile merging passed. Rootless WSL execution passed seven of eight groups; reconfiguration failed at tests/partitions_test.py:543 waiting for TRUSTED, also in isolation. The cause remains unconfirmed, so this draft is not merge-ready. Meaningful coverage gains depend on the separate instrumentation fix.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@achamayou
Amaury Chamayou (achamayou) marked this pull request as ready for review September 9, 2026 17:50
@achamayou
Amaury Chamayou (achamayou) requested a review from a team as a code owner September 9, 2026 17:50
Copilot AI lite review requested due to automatic review settings September 9, 2026 17:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow-only change is consistent with existing CI usage of the partitions configuration and should correctly include partition tests in coverage runs without altering test implementations.

Pull request overview

This PR updates the Coverage GitHub Actions workflow to explicitly execute the partitions CTest configuration/label selection before coverage aggregation, ensuring partition scenarios are included in collected coverage data.

Changes:

  • Add a dedicated “Run partitions tests” workflow step that runs ./tests.sh with -C partitions and -L '^partitions$'.
  • Fail the workflow if the partitions selection would otherwise run zero tests via --no-tests=error.

Custom instructions used:

  • .github/skills/formatting-and-linting/SKILL.md (formatting-and-linting skill)
File summaries
File Description
.github/workflows/coverage.yml Adds a partitions test execution step prior to coverage report generation so partition scenarios contribute to coverage.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Install CI checks dependencies

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants