Include partition tests in coverage workflow - #8321
Include partition tests in coverage workflow#8321Amaury Chamayou (achamayou) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The workflow-only change is consistent with existing CI usage of the partitions configuration and should correctly include partition tests in coverage runs without altering test implementations.
Pull request overview
This PR updates the Coverage GitHub Actions workflow to explicitly execute the partitions CTest configuration/label selection before coverage aggregation, ensuring partition scenarios are included in collected coverage data.
Changes:
- Add a dedicated “Run partitions tests” workflow step that runs
./tests.shwith-C partitionsand-L '^partitions$'. - Fail the workflow if the partitions selection would otherwise run zero tests via
--no-tests=error.
Custom instructions used:
.github/skills/formatting-and-linting/SKILL.md(formatting-and-linting skill)
File summaries
| File | Description |
|---|---|
.github/workflows/coverage.yml |
Adds a partitions test execution step prior to coverage report generation so partition scenarios contribute to coverage. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
Run the existing partition suite before coverage aggregation; other tests and reporting are unchanged.
-C partitionsis required by CTest registration. The motivating coverage run omitted this suite.Validation: Workflow checks and profile merging passed. Rootless WSL execution passed seven of eight groups; reconfiguration failed at
tests/partitions_test.py:543waiting forTRUSTED, also in isolation. The cause remains unconfirmed, so this draft is not merge-ready. Meaningful coverage gains depend on the separate instrumentation fix.