Instrument first-party libraries in coverage reports - #8322
Draft
Amaury Chamayou (achamayou) wants to merge 1 commit into
Draft
Instrument first-party libraries in coverage reports#8322Amaury Chamayou (achamayou) wants to merge 1 commit into
Amaury Chamayou (achamayou) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the missing native implementation coverage exposed by Coverage run 34252103362. Application and test translation units were instrumented, but separately compiled first-party libraries were not.
ccf,ccf_launcher,ccf_js,ccf_kv,ccf_endpoints,ccf_tasks,ccf_pal,ccf_threading, andccfcrypto) whenCOVERAGE=ON: all 80 implementation translation units now receive counters and coverage mapping.COVERAGE=OFF, third-party code and Rust instrumentation unchanged.coverage-report-htmlartifact name and its rootindex.html.Validation performed
All development, builds, tests and coverage commands ran in Ubuntu-26.04 WSL, using Clang/LLVM 21.1.8 and a session-isolated native build based on
e4cc4fb1b4f3a0524f69e803c67d2d6eb6aca8dc, configured withDebug,COVERAGE=ONandLONG_TESTS=ON. Builds used-j1; no production behavior or test assertions were changed.base64_test,crypto_test,kv_test,task_system_test,js_test, andjwt_auth_test. All six reporting regressions passed. Targeted formatting, shell, ASCII, copyright/comment, whitespace and existing test-bucket checks passed.e2e_loggingande2e_logging_http2, using the existingCR_FILTER,-j1and unchanged 360-second timeout and assertions. The runner verified the complete original inventory and exactly one executed group per result; none was skipped.Successful selected-test report, not a full-workflow baseline
This report uses only the six passing unit profiles plus 46 successful serial logging-node profiles, with a fixed inventory of ten already-built binaries. Failed canonical and partition profiles are excluded. All 12 sentinels have genuine nonzero node-runtime hits, and the instrumentation guard passes.
These percentages are not compared with the old report's denominator: previously invisible implementation code is now included.
Remaining limitations / related work