Make generator path quoting test cross-platform - #1812
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
|
Copilot is there a better way to get the Mono runtime on the machine for the tests that doesn't require "sudo" on the agent? Or is this the recommended way of doing it? |
There was a problem hiding this comment.
🟡 Changes recommended
The Linux CI installation can block awaiting confirmation unless apt-get install includes -y.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Makes generator path-quoting tests cross-platform and expands Linux PR validation.
Changes:
- Uses platform-native path separators in quoting tests.
- Runs portable test projects on Linux with Mono support.
- Mono installation must add
-yto prevent CI from hanging or aborting.
File summaries
| File | Description |
|---|---|
test/CsWin32Generator.BuildTasks.Tests/BuildTaskTests.cs |
Makes path-quoting assertions platform-neutral. |
.github/workflows/build.yml |
Expands Linux test coverage; requires non-interactive Mono installation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
For GitHub-hosted |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 269885ab-a187-403f-81ef-4421f979d78f
| - name: ⚙️ Install Mono | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y --no-install-recommends mono-complete |
There was a problem hiding this comment.
Should this be pinned to some target version? Or does the ubuntu-latest have the right inventory control?
Summary
Validation
dotnet test test\CsWin32Generator.BuildTasks.Tests -c Release --filter "TestCategory!=HighMemory&TestCategory!=RequiresHardware" --no-builddotnet test test\GenerationSandbox.Tests -c Release --filter "TestCategory!=HighMemory&TestCategory!=RequiresHardware" --no-builddotnet test test\GenerationSandbox.Unmarshalled.Tests -c Release --filter "TestCategory!=HighMemory&TestCategory!=RequiresHardware" --no-buildFixes the Linux failure in official build
15191331for version0.3.332and closes the PR-validation coverage gap that allowed it through.