Unify poster HTML, PDF, PNG, and Reel pixel fidelity - #41
Merged
LingAo Xiao (ArmandXiao) merged 1 commit intoAug 17, 2026
Merged
Conversation
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
srcdocidentical over HTTP and directfile://, with the wordmark bundled as a runtime assetThis PR supersedes #39 and #40 and is the only one that should be merged.
Root cause
PR #37 made the standalone HTML reload path durable, but Arial was frozen to DejaVu Sans before the source baseline was captured. On the real MSRA117 poster, the metric change reflowed a research figure from 95.20% fill to 79.16%. The later validator only saw the already-shrunken layout.
The combined implementation maps Arial to bundled Arimo, validates migration before accepting a new authoritative baseline, and keeps all of #39's later durable and pixel-equality gates. It also preserves completed legacy logo bakes whose original auto-track width can no longer be recovered safely.
Validation
All tests below were rerun on this combined branch. Test data and results stayed under
/tmpand are not included in the PR.fit_logos.py --selftest, changed CLI help paths,git diff --check, andskill-creatorvalidation forpaper2posterandpaper2reelpassverify-finalpasses; repeated legacy and new-format rerenders produce byte-identical PNGsverify-finalpasses. The historical 79.898% figure is preserved only with the explicit legacy minimum-floor token95.20% -> 79.16%with exit 2 and rolls back HTML, PDF, PNG, and font assets unchangedfile://screenshots are byte-identical at 1365x768, 1440x900, 1920x1080, and 2560x1440, with 0 differing pixels; repeated warm captures also have 0 differences; HTTP Range returns 206Design-as-Code's page dimensions and page count are correct, but its pre-existing 24.26 MB PDF remains above the checker's 20 MB size cap.
PR hygiene
Exactly 12 production skill/runtime paths are included, matching the union of #39 and #40. No test files, screenshots, logs, generated posters, or audit results are included.