Skip to content

Emit object for Web IDL object types#2513

Open
Bashamega wants to merge 2 commits into
microsoft:mainfrom
Bashamega:object-handle
Open

Emit object for Web IDL object types#2513
Bashamega wants to merge 2 commits into
microsoft:mainfrom
Bashamega:object-handle

Conversation

@Bashamega

Copy link
Copy Markdown
Contributor

closes #2475

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
@saschanaz

Copy link
Copy Markdown
Contributor

This will need some test against DT. I think it needed maintainer permission? @jakebailey

@jakebailey

Copy link
Copy Markdown
Member

As in, pull into TS and then try to run it?

Probably not so easy now that we can't test nightlies on DT anymore (until that infra is reworked), but potentially still possible to an extent

@jakebailey

Copy link
Copy Markdown
Member

I do expect this to be very breaking, however. The toJSON changes alone scare me a bit at first glance (but, I know what I said on the issue, of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emit object for Web IDL object types?

3 participants