Retire embedded Aspire skills bundle by ellahathaway · Pull Request #20947 · microsoft/aspire

Ella Hathaway (ellahathaway) · 2026-10-13T00:33:13Z

Description

Removes the embedded Aspire skills bundle and its acquisition/runtime machinery after #20946. --aspire-skills now supports native|none, defaults to native client registration, and no longer copies a bundled archive into client skill directories. Existing copied Aspire skills are detected before native registration so the CLI does not silently create an ambiguous configuration.

Telemetry hook scripts remain embedded because the Aspire CLI installs and executes them independently of the plugin. Aspire now owns those script sources directly: this removes the cross-repository updater/verifier workflows, provenance metadata, synchronization scripts, and protected synchronization-branch routing. Future script changes are ordinary Aspire code changes rather than bundle synchronization. The canonical track-telemetry.sh and track-telemetry.ps1 bytes are unchanged.

This is the final layer of stack #20948 (#20932 → #20946 → #20947). Related to #20246 and epic #20245.

Merge gates: #20946 and the corresponding microsoft/aspire-skills catalog release must be ready before this retirement layer lands. No formal security review has been completed for this PR.

Validation:

dotnet build src\Aspire.Cli\Aspire.Cli.csproj --no-restore --nologo --verbosity quiet /p:SkipNativeBuild=true — passed.
dotnet build tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-restore --nologo --verbosity quiet /p:SkipNativeBuild=true — passed.
dotnet build tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-restore --nologo --verbosity quiet /p:SkipNativeBuild=true — passed.
Focused agent, MCP, init/new, bootstrap, and configuration tests — 866 passed, 10 expected platform/filesystem skips, 0 failed (876 total). An earlier two-thread run hit two existing 5-second timeouts; all 8 parameterized retry cases passed in isolation and the complete serial rerun passed.
Focused test-trigger routing and scheduled-workflow monitoring tests — 293 passed, 0 failed.
dotnet build /t:UpdateXlf src\Aspire.Cli\Aspire.Cli.csproj --no-restore --nologo --verbosity quiet /p:SkipNativeBuild=true — passed with no generated changes.
Hook blobs remain a4f26ccb1925e48a26c1506fda20b636cfc27184 (track-telemetry.sh) and ff6c8b3f9a2f4b6762d0d890dfa57419e66f73e5 (track-telemetry.ps1).

The CLI builds emitted only the existing MessagePack 2.5.302 NU1902 advisory. Validation was on Windows ARM64. Bash, quarantined, outerloop, E2E runtime, full-repository, Native AOT, downloaded-artifact, live catalog acquisition, post-push CI, and formal security-review validation were not run. No snapshot baselines changed.

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No

github-actions · 2026-10-13T01:12:12Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-13T01:33:21Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-13T01:55:06Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-13T02:15:55Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-13T02:48:15Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-13T02:58:10Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-15T15:58:16Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20947

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20947"

## Description Users should choose their agents, not skill folders. `agent init`, `new`, and `init` now share client selection and project/global scope. - Use stable CLI IDs `copilot`, `claude`, and `opencode`, with localized GitHub Copilot, Claude Code, and OpenCode labels. - Prompt **agents → assets → scope**. Preselect detected agents; use Copilot only when none are detected. - Write only to selected clients and scope, deduplicating shared destinations. Selecting no agents/assets performs no agent writes. MCP remains a standalone opt-in. - Keep scanners read-only, client metadata focused on destinations, and configuration writes in shared helpers. This PR provides the foundation for `aspire-skills` plugin support by letting users choose their agent clients and installation scope rather than filesystem locations. Clients can share skill directories while requiring different native plugin registration, so client selection determines which installation behavior is needed, while detection supplies sensible defaults. This keeps the user-facing flow stable as native plugin support is added, while preserving copied-skill installation in this intermediate layer. This layer retains **copied skills and the existing bundle**. Native plugins [#20946](#20946) and bundle retirement [#20947](#20947) remain separate follow-ups. ```shell aspire agent init --agents claude --scope project --skills aspire --mcp=false ``` Related to #20247 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f73663-c37c-4c5a-b83d-89f0b8d13c5f

github-actions · 2026-10-16T18:52:36Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-16T19:01:33Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-16T19:22:00Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-16T21:28:34Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-16T21:44:41Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-16T21:54:57Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Remove the cross-repository updater, verifier, provenance metadata, and protected synchronization branch while retaining the embedded runtime scripts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-10-16T22:44:25Z

Tests selector

Selects the full PR test matrix + all PR-gated jobs (ALL) — run-all fallback: 'eng/scripts/aspire-skills-bundle.common.ps1' is neither Layer-1-owned nor matched by a Layer 2 rule

Selection computed for commit cd1ddee.

github-actions · 2026-10-16T23:49:54Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-17T00:06:49Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-10-17T00:26:04Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-advanced-security Bot found potential problems Oct 13, 2026

View reviewed changes

This was referenced Oct 13, 2026

Separate telemetry hook maintenance from skills bundles #20283

Closed

Select supported agent clients and configuration scope #20932

Merged

Ella Hathaway (ellahathaway) added this pull request to stack #20948 October 13, 2026 00:40

This comment has been minimized.

Sign in to view

Ella Hathaway (ellahathaway) mentioned this pull request Oct 13, 2026

Configure native agent plugins #20946

Draft

5 of 14 tasks

github-actions Bot mentioned this pull request Oct 13, 2026

[repo-pulse] Daily Report #16404

Open

Ella Hathaway (ellahathaway) force-pushed the ellahathaway-hook-only-maintenance branch from ea92732 to d07155a Compare October 15, 2026 15:57

Ella Hathaway (ellahathaway) force-pushed the ellahathaway-hook-only-maintenance branch 2 times, most recently from c7277cb to 792f4eb Compare October 16, 2026 18:12

github-advanced-security Bot found potential problems Oct 16, 2026

View reviewed changes

Comment thread .github/workflows/verify-telemetry-hooks.yml Fixed

This comment has been minimized.

Sign in to view

Ella Hathaway (ellahathaway) force-pushed the ellahathaway-hook-only-maintenance branch from 792f4eb to 673c82a Compare October 16, 2026 20:34

This comment has been minimized.

Sign in to view

Ella Hathaway (ellahathaway) and others added 10 commits October 16, 2026 15:27

Separate telemetry hook maintenance from skills bundles

50a3858

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Focus hook README on the current workflow

418666e

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Pin telemetry hook synchronization checkout to main

6d75be8

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Remove obsolete bundle verifier from PR testing guidance

0098d71

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Retire embedded Aspire skills bundle

0a2aacf

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Preserve telemetry hook bytes on replay

246c360

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Update retirement command tests

eca8ede

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Align retirement tests with native registration

9ea125d

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Align retirement with configuration editor

a63a62a

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Keep telemetry hooks in Aspire

cd1ddee

Remove the cross-repository updater, verifier, provenance metadata, and protected synchronization branch while retaining the embedded runtime scripts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Ella Hathaway (ellahathaway) force-pushed the ellahathaway-hook-only-maintenance branch from 673c82a to cd1ddee Compare October 16, 2026 22:41

Conversation

Ella Hathaway (ellahathaway) commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 13, 2026

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Tests selector

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ella Hathaway (ellahathaway) commented Oct 13, 2026 •

edited

Loading