rust: Upgrade rust to 1.98.1 - #18785
Open
Kavya Sree Kaitepalli (KavyaSree2610) wants to merge 8 commits into
Open
Kavya Sree Kaitepalli (KavyaSree2610) wants to merge 8 commits into
Kavya Sree Kaitepalli (KavyaSree2610) wants to merge 8 commits into
Conversation
Kavya Sree Kaitepalli (KavyaSree2610)
force-pushed
the
kkaitepalli/rust-upgrade-1.98.1
branch
from
September 14, 2026 04:51
1e3f537 to
94a6b66
Compare
Kavya Sree Kaitepalli (KavyaSree2610)
marked this pull request as ready for review
September 15, 2026 04:51
Kavya Sree Kaitepalli (KavyaSree2610)
requested review from
a team
as code owners
September 15, 2026 04:51
| Summary: Prebuilt stage0 bootstrap toolchain used to build rust | ||
| Name: rust-bootstrap | ||
| Version: 1.95.0 | ||
| Version: 1.97.1 |
There was a problem hiding this comment.
looks like we missed a changelog entry
There was a problem hiding this comment.
updated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Upgrades
rustto 1.98.1, bootstrapped via a newrust-bootstrap1.97.1 stage0 toolchain, and re-evaluates/rebases the full set of downstream CVE patches against the new source tree. Also backports an upstreamrustixfix needed forkata-containers-ccandtardev-snapshotterto keep building against the newer rustc.Change Log
rust: 1.96.1 -> 1.98.1;stage0_version/release_datebumped to 1.97.1 / 2026-07-16rust-bootstrap: 1.95.0 -> 1.97.1 stage0 toolchain, updatedrust-bootstrap.signatures.jsonkata-containers-cc: 3.15.0.aks0-18 -> 3.15.0.aks0-19; backported upstreambytecodealliance/rustix#1663(rustix-remove-rustc-attrs.patch) to build with the newer rustc. This patch was needed because kata-containers-cc (and tardev-snapshotter ) vendor an old copy of the rustix crate (0.37.x). That old version's build.rs probes for the unstable Rust feature #![feature(rustc_attrs)] , and if detected, enables a rustc_attrs cfg flag. When enabled, it applies internal/unstable compiler attributes - rustc_layout_scalar_valid_range_start / _end and rustc_nonnull_optimization_guaranteed - to Errno , BorrowedFd , and OwnedFd for niche-layout optimizations.What changed in Rust 1.98.1: Starting around rustc 1.97 (rust-lang/rust#155433, #156510), as part of an ongoing migration to "pattern types," rustc stopped allowing these internal rustc_* attributes to be used by external (non-compiler) crates. So when the old vendored rustix tries to use them, the build now fails
tardev-snapshotter: 3.2.0.tardev1-10 -> 3.2.0.tardev1-11; applied the same rustix backport manually against the cached rustix 0.37.27 sources (outside the main autosetup source tree)rust-by-examplesearch index outputcgmanifest.jsonwith the newrust/rust-bootstrapversions and download URLsrustCVE patches -fixed upstream by vendored dependency bumps in 1.98.1protobuf3.7.2, which splitsskip_group/merge_messageinto depth-checked variants, preventing uncontrolled recursion.gix-submodule0.32.0, which verifies the update value didn't originate from.gitmodulesbefore allowing aCommand, closing the RCE bypass.gix0.85.0, which validates submodule names and rejects..path-traversal segments before deriving submodule git directories.gix0.85.0, which no longer follows symlinks when reading the worktree.gitmodulesfile.gix-validate0.11.2, which replaces the single-match..check with a full path-component scan, closing the traversal bypass.rustCVE patches droppedExisting Capstone-related patches removed(Capstone disassembler no longer in scope):
Does this affect the toolchain?
NO
Workitems
https://microsoft.visualstudio.com/OS/_workitems/edit/64124157
Test Methodology