Skip to content

Fixing an incorrect 500 error response. - #5732

Open
v-isyamauchi-gh wants to merge 2 commits into
mainfrom
personal/v-isyamauchi/196788
Open

Fixing an incorrect 500 error response.#5732
v-isyamauchi-gh wants to merge 2 commits into
mainfrom
personal/v-isyamauchi/196788

Conversation

@v-isyamauchi-gh

Copy link
Copy Markdown
Contributor

Description

The change will fix two issues.

  • An incorrect 500 error response when a request contains a mix of smart v1 and v2 scopes.
  • An unnecessary routing of a request to the custom error endpoint.

Related issues

Addresses [issue #196788].
Bug 196788: FHIR incident 826328930: mixed SMART v1/v2 scopes return 500 instead of a handled auth error

Testing

Tested by manual testing and running the smart UTs.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@v-isyamauchi-gh v-isyamauchi-gh added this to the CY25Q3/2Wk07 milestone Aug 18, 2026
@v-isyamauchi-gh
v-isyamauchi-gh requested a review from a team as a code owner August 18, 2026 17:03
@v-isyamauchi-gh v-isyamauchi-gh added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Open source This change is only relevant to the OSS code or release. No-PaaS-breaking-change No-ADR ADR not needed labels Aug 18, 2026
@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.17%. Comparing base (1c9df51) to head (5597397).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5732      +/-   ##
==========================================
+ Coverage   77.08%   77.17%   +0.08%     
==========================================
  Files        1011     1011              
  Lines       37262    37316      +54     
  Branches     5680     5683       +3     
==========================================
+ Hits        28724    28797      +73     
+ Misses       7167     7139      -28     
- Partials     1371     1380       +9     

see 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. No-ADR ADR not needed No-PaaS-breaking-change Open source This change is only relevant to the OSS code or release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants