Skip to content

CI: upgrade ESRP signing tasks to Node20 #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dan Legg (danlegg) merged 2 commits into from
Nov 4, 2026
Merged

CI: upgrade ESRP signing tasks to Node20 #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6854581
CI: use Node20 ESRP signing tasks
danlegg Nov 3, 2026
24970e2
CI: complete ESRP Node20 upgrade for official build jobs
danlegg Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines/templates/DotNet.Build.Job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:

- ${{ if eq(parameters.isOfficialBuild, true) }}:
- ${{ each framework in split('net8.0,net10.0', ',') }}:
- task: EsrpCodeSigning@5
- task: EsrpCodeSigning@6
displayName: Sign Microsoft.Mxc.Sdk.dll (${{ framework }})
inputs:
ConnectedServiceName: ${{ parameters.ESRPInfo.serviceName }}
Expand Down
2 changes: 1 addition & 1 deletion .azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ jobs:
displayName: 'Assemble test bundle'

# Test sign (CP-230072) the staged binaries so the vpack ships signed binaries.
- task: EsrpCodeSigning@5
- task: EsrpCodeSigning@6
displayName: Code Sign
inputs:
ConnectedServiceName: ${{ parameters.ESRPInfo.serviceName }}
Expand Down
4 changes: 2 additions & 2 deletions .azure-pipelines/templates/Mac.Build.Job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
displayName: 'Zip binaries for ESRP signing'
condition: and(succeeded(), eq(${{ parameters.isOfficialBuild }}, true))

- task: EsrpCodeSigning@5
- task: EsrpCodeSigning@6
displayName: 'Sign macOS binary (ESRP)'
condition: and(succeeded(), eq(${{ parameters.isOfficialBuild }}, true))
inputs:
Expand All @@ -140,7 +140,7 @@ jobs:
}
]

- task: EsrpCodeSigning@5
- task: EsrpCodeSigning@6
displayName: 'Notarize macOS binary (ESRP)'
condition: and(succeeded(), eq(${{ parameters.isOfficialBuild }}, true))
inputs:
Expand Down
2 changes: 1 addition & 1 deletion .azure-pipelines/templates/Rust.Build.Job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ jobs:
workingDirectory: $(Build.SourcesDirectory)/src
condition: and(eq('${{ item.os }}', 'linux'), eq('${{ item.arch }}', 'x64'))

- task: EsrpCodeSigning@5
- task: EsrpCodeSigning@6
displayName: Code Sign
condition: and(eq(${{ parameters.isOfficialBuild }}, true), eq('${{ item.os }}', 'windows'))
inputs:
Expand Down
Loading