ci: make development release uploads resumable - #103
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 17, 2026 23:47
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The configured timeout cannot cover the retry budget, and buffered output can hide upload progress during cancellation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced (auto)
Findings: 1
Note
Copilot is running an experiment and ran this review at Balanced.
Open (2)
What changed in this PR
Makes development release publishing resumable and resilient to transient upload failures.
Changes:
- Adds per-asset verification, retries, backoff, and draft publication gating.
- Replaces shell publishing with a tested Python implementation.
- Extends CI validation and release timeout.
| File | Description |
|---|---|
scripts/nvx_tools/development_release.py |
Implements resumable release publishing. |
scripts/publish_development_release.py |
Adds the CI entry point. |
scripts/test_development_release.py |
Adds focused regression tests. |
.github/actions/publish-development-release/action.yml |
Invokes the new publisher. |
.github/actions/validate-nvx/action.yml |
Runs the new tests. |
.github/workflows/ci.yml |
Increases the release-job timeout. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
force-pushed
the
feat-ci-reliability
branch
from
September 18, 2026 00:39
4ccd237 to
53a2f6c
Compare
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 18, 2026 00:39
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The production release path depends on external GitHub API and CLI state transitions that require final human validation.
Review effort: Balanced (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Balanced.
Resolved since last review (2)
Pedro Henrique Penna (ppenna)
marked this pull request as ready for review
September 18, 2026 00:44
Pedro Henrique Penna (ppenna)
force-pushed
the
feat-ci-reliability
branch
from
September 18, 2026 00:49
53a2f6c to
bc6f5f4
Compare
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 18, 2026 00:49
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Production release mutation, deletion, retries, and publication involve external state transitions that warrant final human review.
Review effort: Balanced (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Balanced.
Create or reuse the development release as an explicit draft before transferring assets. Upload each platform package independently, verify its remote size and SHA-256 when available, and preserve already-valid assets across reruns. Bound every upload attempt to three minutes and retry transient GitHub 5xx, timeout, connection, and duplicate-asset failures with exponential backoff. Re-query the release after every upload result so a request that completed server-side is accepted without retransmission, while only a specific mismatched asset is removed before retrying. Require the exact three-package asset set before publishing the draft as a prerelease, and leave the release unpublished on any verification or retry failure. Allow 90 minutes for the release job so the configured upload, verification, and partial-asset cleanup budget can complete with artifact-handling headroom, and run Python unbuffered so package-level progress remains visible during slow uploads and cancellation. Keep release metadata parsing fully type-safe under the pinned Pyright configuration without redundant casts, and format the publisher with the pinned Ruff version. Add focused regression coverage for retry success and exhaustion, partial draft resume, mismatched assets, server-side completion, and publication gating. Validation: - python3 scripts/nvx.py verify - pinned Ruff check and format checks for scripts - pinned Pyright checks for Linux and Windows - python3 -m unittest scripts/test_development_release.py -v - full Linux validate-nvx command sequence - changed workflow and composite-action YAML parsed successfully Refs #74 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fdacb24e-53c2-4118-9196-d4c194a33187
Pedro Henrique Penna (ppenna)
force-pushed
the
feat-ci-reliability
branch
from
September 18, 2026 22:26
bc6f5f4 to
27b2cb5
Compare
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 18, 2026 22:26
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
CI run
35270530890, attempt 2, at head3644cbc18c57b900c61bdcd0ce8b6a64586f7b4bspent the full 10-minute job budget inside one multi-assetgh release createoperation and was canceled on September 17, 2026. The command left a partial draft release. The previous rerun path used a singlegh release upload --clobber, which retransferred valid assets, could delete completed work before a replacement succeeded, and never published a draft left by a failed create.The new publisher resumes that draft safely, identifies the individual package that failed, and keeps the release unpublished until all assets are verified. Each upload attempt is capped at three minutes, while the 90-minute job timeout covers the configured upload, verification, and partial-asset cleanup budget across all three assets with artifact-handling headroom. Unbuffered Python output ensures attempt and elapsed-time messages are emitted promptly.
Validation
python3 scripts/nvx.py verifypython3 -m unittest scripts/test_development_release.py -v.github/actions/validate-nvx/action.ymlThe existing same-run workflow artifact names and producer/consumer dependencies are unchanged; no
github.run_attemptscoping was added.Fixes #74