Bind platform release artifacts to build provenance - #114
Merged
Pedro Henrique Penna (ppenna) merged 12 commits intoSep 19, 2026
Merged
Pedro Henrique Penna (ppenna) merged 12 commits into
Pedro Henrique Penna (ppenna) merged 12 commits into
Conversation
Enrique Saurez (esaurez)
marked this pull request as ready for review
September 18, 2026 17:18
Pedro Henrique Penna (ppenna)
force-pushed
the
esaurez/nvx-platform/01-kernel-20260918
branch
3 times, most recently
from
September 18, 2026 21:53
ad87797 to
d9796f7
Compare
Base automatically changed from
esaurez/nvx-platform/01-kernel-20260918
to
dev
September 18, 2026 22:14
Enrique Saurez (esaurez)
force-pushed
the
esaurez/nvx-platform/02-provenance-20260918
branch
from
September 18, 2026 22:27
464fe6c to
94f4a48
Compare
Copilot started reviewing on behalf of
Enrique Saurez (esaurez)
September 18, 2026 22:28
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Checksum verification does not enforce complete coverage, and published archives remain mutable and nondeterministic.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds provenance-aware release packaging for NVX platform artifacts.
Changes:
- Records and validates OpenVMM and kernel provenance.
- Stages release trees atomically with manifests and checksums.
- Transfers provenance through Docker builds, caches, and CI artifacts.
| File | Description |
|---|---|
SOURCE-MANIFEST.json |
Adds OpenVMM contract metadata. |
scripts/test_nvx_tools.py |
Tests provenance, tampering, and publication recovery. |
scripts/nvx.py |
Exposes OpenVMM provenance recording. |
scripts/nvx_tools/release.py |
Validates and packages provenance-aware releases. |
scripts/nvx_tools/build.py |
Generates kernel and OpenVMM provenance. |
docker/Dockerfile |
Exports kernel provenance. |
doc/build.md |
Documents release provenance and layout. |
.github/workflows/ci.yml |
Transfers provenance artifacts between jobs. |
.github/actions/build-openvmm/action.yml |
Caches OpenVMM binaries with provenance. |
.github/actions/build-guest-artifacts/action.yml |
Caches kernel artifacts with provenance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Enrique Saurez (esaurez)
September 18, 2026 23:43
View session
Add generic kernel and OpenVMM provenance sidecars, verify them during release packaging, and publish staged release trees with exact manifest hashes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep provenance fixtures aligned with the inherited fc0e30ee gitlink while production code continues to derive revisions dynamically. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document the exact producer archive paths and non-self-referential SHA256SUMS coverage for downstream composition. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Capture kernel inputs before compilation, validate source metadata during packaging, and recheck replacement policy at publication time. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep test metadata aligned with the inherited dev gitlink without modifying the OpenVMM submodule reference. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use a new provenance-aware cache generation, verify the sidecar on restore, and carry it with each OpenVMM artifact into downstream platform jobs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the kernel cache generation name stable and document why OpenVMM artifacts restore at the repository root when they carry both binary and provenance paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Cached kernel-source mutation can produce inaccurate provenance, and malformed dot-root archives trigger an uncaught exception.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
Resolved since last review (2)
Comment on lines
+640
to
+642
| if ( | ||
| _kernel_source_fingerprint() != source_fingerprint | ||
| or sha256_file(input_config) != input_config_sha256 |
Comment on lines
510
to
+518
| if ( | ||
| not name | ||
| or "\\" in name | ||
| not normalized_name | ||
| or "\\" in normalized_name | ||
| or path.is_absolute() | ||
| or "." in path.parts | ||
| or ".." in path.parts | ||
| or (path.parts and path.parts[0].endswith(":")) | ||
| or any(":" in part for part in path.parts) | ||
| or path.as_posix() != normalized_name | ||
| or (not is_directory and name.endswith("/")) |
Narrow OpenVMM artifact transfers, require complete checksum manifests, and create deterministic release archives with collision-safe GitHub asset publication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Read back deterministic archives through a safe exact-layout extraction before publication, and preserve split artifact uploads across same-run retries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Capture validated release files through checked descriptors into a private snapshot, then bind archive readback to the accepted inventory and hashes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reject missing or mismatched pre-existing development release asset metadata without mutation while preserving owned-upload cleanup and resumable matching behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enrique Saurez (esaurez)
force-pushed
the
esaurez/nvx-platform/02-provenance-20260918
branch
from
September 19, 2026 00:03
9e3060e to
bacca2c
Compare
Copilot started reviewing on behalf of
Enrique Saurez (esaurez)
September 19, 2026 00:04
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Source-package races and type-loose provenance validation can still produce authenticated but inconsistent metadata.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Comment on lines
+797
to
+798
| provenance.get("format") != 1 | ||
| or provenance.get("source_revision") != revision |
Comment on lines
+1128
to
+1132
| _copy_release_file( | ||
| linux_source_archive, | ||
| source_destination / linux_source_archive.name, | ||
| ) | ||
| _project_source_archive( |
|
|
||
|
|
||
| def verify_sha256_sums(directory: Path) -> None: | ||
| def verify_sha256_sums(directory: Path) -> VerifiedChecksumInventory: |
Pedro Henrique Penna (ppenna)
approved these changes
Sep 19, 2026
Pedro Henrique Penna (ppenna)
deleted the
esaurez/nvx-platform/02-provenance-20260918
branch
September 19, 2026 00:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Produce an immutable, self-describing NVX platform release whose binaries, kernel inputs, source metadata, and legal material can be authenticated by downstream composition.
Main changes
SHA256SUMSto cover every packaged file and capture a private verified snapshot before archive creation.Rationale
NVX owns distribution of the kernel and VMM. Downstream products need an immutable platform artifact with independently verifiable provenance rather than rebuilding, inferring, or trusting mutable directories. The release remains product-neutral and contains no deployment or guest-agent policy.
Validation