scripts: Run OpenVMM doctests with unit tests - #131
Merged
Merged
Conversation
Extend test-openvmm-unit to run the workspace doctests after the cargo-nextest suite. Use Cargo's locked workspace mode and disable fail-fast so all doctest failures are reported. Update command-construction coverage to verify both test phases while preserving the existing package exclusions. Refresh the CLI help and usage documentation to describe the expanded behavior.
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 19, 2026 20:32
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation, tests, and documentation consistently cover the expanded test behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds OpenVMM workspace doctests to the existing unit-test CI entry point.
Changes:
- Runs locked workspace doctests after cargo-nextest.
- Tests both generated commands.
- Updates CLI help and usage documentation.
| File | Description |
|---|---|
scripts/nvx_tools/ci.py |
Adds the Cargo doctest invocation. |
scripts/test_nvx_tools.py |
Verifies nextest and doctest commands. |
scripts/nvx.py |
Expands CLI help text. |
doc/usage.md |
Documents doctest execution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo-nextestunit-test suite so Rust documentation examples are covered by the CI entry pointValidation
cargo test --locked --doc --workspace --no-fail-faston Windows/WHP (prometheus28)cargo test --locked --doc --workspace --no-fail-faston Linux/MSHV (prometheus30)cargo test --locked --doc --workspace --no-fail-faston Linux/KVM (prometheus32)