fix(cargo-anvil): parse single-quoted llvm-cov paths - #192
Open
martin-kolinek wants to merge 2 commits into
Open
martin-kolinek wants to merge 2 commits into
martin-kolinek wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Fixes cargo-anvil’s Windows llvm-cov fallback to parse single-quoted executable paths.
Changes:
- Adds single-quoted path parsing and fallback coverage.
- Regenerates recipes, snapshots, and lock metadata.
- Updates response-file contract tests.
File summaries
| File | Description |
|---|---|
justfiles/anvil/checks/llvm-cov.just |
Generated recipe update |
crates/cargo-anvil/tests/snapshots/snapshots__local_only.snap |
Updated local snapshot |
crates/cargo-anvil/tests/snapshots/snapshots__github_backend.snap |
Updated GitHub snapshot |
crates/cargo-anvil/tests/snapshots/snapshots__ado_backend.snap |
Updated ADO snapshot |
crates/cargo-anvil/tests/recipe_contracts.rs |
Windows fallback tests |
crates/cargo-anvil/templates/justfiles/anvil/checks/llvm-cov.just |
Source template fix |
.anvil.lock |
Updated generated-file checksums |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (97.6%) is below the target coverage (100.0%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
=====================================
Coverage 97.6% 97.6%
=====================================
Files 304 304
Lines 69683 69683
=====================================
+ Hits 68016 68017 +1
+ Misses 1667 1666 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The multiline contract fixture no longer matches and needs adjustment to preserve regression coverage.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Lite
| } | ||
| $command = "$quote$($env:FAKE_LLVM_COV_PATH)$quote export $arguments" | ||
| if ($env:FAKE_LLVM_COV_MULTILINE) { | ||
| $command = $command.Replace(' -object', "`n-object") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Accept single-quoted executable paths in cargo-anvil's Windows error-206 coverage fallback.
Problem
cargo-llvm-cov can render its failed
llvm-cov exportcommand with a single-quoted executable path. The fallback parser accepted double-quoted and bare paths only, retained the quote characters as part of the executable name, and failed instead of retrying through the response file.Observed in microsoft/oxidizer#767 on the full Windows coverage workspace: https://github.com/microsoft/oxidizer/actions/runs/35362373841/job/105656828788
Change
Validation
cargo anvil --dry-run