chore: align lint configuration with cargo-anvil - #769
martin-kolinek wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Update stale Anvil lockfile checksums and preserve the workspace missing_docs policy.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Aligns lint configuration with cargo-anvil 0.9 while preserving repository-specific identifier settings.
Changes:
- Restores the managed workspace lint catalog.
- Moves custom identifier configuration outside managed regions.
- Reorganizes profiles and patches.
File summaries
| File | Summary |
|---|---|
clippy.toml |
Preserves repository-specific identifier tuning outside the managed Clippy region. |
Cargo.toml |
Reorganizes managed workspace lints and configuration boundaries. |
Review details
Suppressed comments (1)
Cargo.toml:427
- Removing
rust.missing_docs = "warn"removes the workspace-wide documentation check for crates inheriting[lints] workspace = true; for example,crates/observed/Cargo.toml:72-73opts into that policy whilecrates/observed/src/lib.rs:7-8still says its localdeny(missing_docs)is temporary until the workspace lint is promoted. This is a behavior regression beyond the documented temporaryempty_structs_with_bracketsgap; retain this lint outside the managed region, or update the dependent crate policy and documentation in the same change.
# <<< anvil-managed: anvil-workspace-lints
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 640 639 -1
Lines 85528 85484 -44
=======================================
- Hits 85528 85484 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The only finding is a minor documentation nit and does not block approval.
Review details
Suppressed comments (1)
Cargo.toml:336
- This migration now places
missing_docsin[workspace.lints.rust], so the four crate-root TODOs incrates/observed/src/lib.rs,crates/observed_utils/src/lib.rs,crates/observed_testing/src/lib.rs, andcrates/arty_executor/src/lib.rsstill claiming it has not been promoted are stale. Please remove or update those comments in this change so the source no longer documents a condition that is now false.
missing_docs = "warn"
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
🤖 Aligns Oxidizer's lint configuration with cargo-anvil's namespace-specific managed-region layout from microsoft/ox-tools#191.
The Rust, rustdoc, and Clippy catalogs now live in separate explicit subtables, so
cargo sort --groupedtreats them as stable sorting units. Oxidizer's repository-specificmissing_docs,unreachable_pub, andclippy::panicrules remain as bare keys immediately after their namespace's closing sentinel.doc-valid-identsremains repository-owned Clippy behavior configuration.This also includes the upstream
empty_structs_with_bracketswarning andliteral_string_with_formatting_argsallow override. The lockfile records the forthcoming region IDs and checksums. Until cargo-anvil 0.12.0 from microsoft/ox-tools#191 is merged and adopted, the currently installed 0.9.0 catalog cannot reconcile these new regions; that temporary ordering gap is intentional.