Skip to content

chore: align lint configuration with cargo-anvil - #769

Open
martin-kolinek wants to merge 3 commits into
mainfrom
chore/align-anvil-lints
Open

martin-kolinek wants to merge 3 commits into
mainfrom
chore/align-anvil-lints

Conversation

@martin-kolinek

@martin-kolinek martin-kolinek commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

🤖 Aligns Oxidizer's lint configuration with cargo-anvil's namespace-specific managed-region layout from microsoft/ox-tools#191.

The Rust, rustdoc, and Clippy catalogs now live in separate explicit subtables, so cargo sort --grouped treats them as stable sorting units. Oxidizer's repository-specific missing_docs, unreachable_pub, and clippy::panic rules remain as bare keys immediately after their namespace's closing sentinel. doc-valid-idents remains repository-owned Clippy behavior configuration.

This also includes the upstream empty_structs_with_brackets warning and literal_string_with_formatting_args allow override. The lockfile records the forthcoming region IDs and checksums. Until cargo-anvil 0.12.0 from microsoft/ox-tools#191 is merged and adopted, the currently installed 0.9.0 catalog cannot reconcile these new regions; that temporary ordering gap is intentional.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 18, 2026 14:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Update stale Anvil lockfile checksums and preserve the workspace missing_docs policy.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Aligns lint configuration with cargo-anvil 0.9 while preserving repository-specific identifier settings.

Changes:

  • Restores the managed workspace lint catalog.
  • Moves custom identifier configuration outside managed regions.
  • Reorganizes profiles and patches.
File summaries
File Summary
clippy.toml Preserves repository-specific identifier tuning outside the managed Clippy region.
Cargo.toml Reorganizes managed workspace lints and configuration boundaries.
Review details

Suppressed comments (1)

Cargo.toml:427

  • Removing rust.missing_docs = "warn" removes the workspace-wide documentation check for crates inheriting [lints] workspace = true; for example, crates/observed/Cargo.toml:72-73 opts into that policy while crates/observed/src/lib.rs:7-8 still says its local deny(missing_docs) is temporary until the workspace lint is promoted. This is a behavior regression beyond the documented temporary empty_structs_with_brackets gap; retain this lint outside the managed region, or update the dependent crate policy and documentation in the same change.
# <<< anvil-managed: anvil-workspace-lints
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Cargo.toml Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 18, 2026 15:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed changes have no unresolved blocking issues.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (36b9e57) to head (b53ec9d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #769   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         640      639    -1     
  Lines       85528    85484   -44     
=======================================
- Hits        85528    85484   -44     
Flag Coverage Δ
linux 100.0% <ø> (ø)
linux-arm 100.0% <ø> (ø)
scheduled ?
windows 100.0% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The only finding is a minor documentation nit and does not block approval.

Review details

Suppressed comments (1)

Cargo.toml:336

  • This migration now places missing_docs in [workspace.lints.rust], so the four crate-root TODOs in crates/observed/src/lib.rs, crates/observed_utils/src/lib.rs, crates/observed_testing/src/lib.rs, and crates/arty_executor/src/lib.rs still claiming it has not been promoted are stale. Please remove or update those comments in this change so the source no longer documents a condition that is now false.
missing_docs = "warn"
  • Files reviewed: 2/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants