Repository navigation
fix(tracing): title the waits in the trace like the Node.js client - #2023
Merged
Merged
Conversation
The wait info sent for waitForConsoleMessage() and the other event waits had no event name and no title, so the trace viewer showed them as __waitInfo__. The before message of a wait now carries the event and the title of the Node.js client, "Wait for event "console"" or "Wait for navigation", set for that message only so that the calls made from the callback of the wait stay visible. The wait of BrowserContext.waitForPage() was reported under the name of BrowserContext.close(). Claude-Session: https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM
Pavel Feldman (pavelfeldman)
approved these changes
Oct 26, 2026
Yury Semikhatsky (yury-s)
merged commit Oct 26, 2026
5883d77
into
microsoft:main
17 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForConsoleMessage()and the other event waits carried no event name and no title, so the trace viewer showed them as__waitInfo__; the before message now carries the event and the Node.js title (Wait for event "console",Wait for navigation), set for that message only so that the calls made from the callback of the wait stay visible.BrowserContext.waitForPage()was reported under the name ofBrowserContext.close().https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM